From: w.sang@pengutronix.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call
Date: Mon, 11 Oct 2010 16:21:04 +0200 [thread overview]
Message-ID: <1286806866-19258-5-git-send-email-w.sang@pengutronix.de> (raw)
In-Reply-To: <1286806866-19258-1-git-send-email-w.sang@pengutronix.de>
The custom init call may need more data to perform its job, so we pass
it a pointer to pdata, too. Also, always use the platform_id specific
data even if platform_data is present. Doing that, platform_data can
additionally be parsed by init() for board-specific information (via
sdhci->mmc->parent).
(Note: the old behaviour was that you could override the platform_id
specific data with your own. However, one can still do this by using the
"sdhci" id instead of "sdhci-<something>".)
Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
Tested-by : Eric B?nard <eric@eukrea.com>
---
drivers/mmc/host/sdhci-pltfm.c | 8 +++++---
include/linux/mmc/sdhci-pltfm.h | 2 +-
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/mmc/host/sdhci-pltfm.c
index 685202b..00e8a8a 100644
--- a/drivers/mmc/host/sdhci-pltfm.c
+++ b/drivers/mmc/host/sdhci-pltfm.c
@@ -52,15 +52,17 @@ static struct sdhci_ops sdhci_pltfm_ops = {
static int __devinit sdhci_pltfm_probe(struct platform_device *pdev)
{
- struct sdhci_pltfm_data *pdata = pdev->dev.platform_data;
const struct platform_device_id *platid = platform_get_device_id(pdev);
+ struct sdhci_pltfm_data *pdata;
struct sdhci_host *host;
struct sdhci_pltfm_host *pltfm_host;
struct resource *iomem;
int ret;
- if (!pdata && platid && platid->driver_data)
+ if (platid && platid->driver_data)
pdata = (void *)platid->driver_data;
+ else
+ pdata = pdev->dev.platform_data;
iomem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!iomem) {
@@ -109,7 +111,7 @@ static int __devinit sdhci_pltfm_probe(struct platform_device *pdev)
}
if (pdata && pdata->init) {
- ret = pdata->init(host);
+ ret = pdata->init(host, pdata);
if (ret)
goto err_plat_init;
}
diff --git a/include/linux/mmc/sdhci-pltfm.h b/include/linux/mmc/sdhci-pltfm.h
index 0239bd7..548d59d 100644
--- a/include/linux/mmc/sdhci-pltfm.h
+++ b/include/linux/mmc/sdhci-pltfm.h
@@ -28,7 +28,7 @@ struct sdhci_host;
struct sdhci_pltfm_data {
struct sdhci_ops *ops;
unsigned int quirks;
- int (*init)(struct sdhci_host *host);
+ int (*init)(struct sdhci_host *host, struct sdhci_pltfm_data *pdata);
void (*exit)(struct sdhci_host *host);
};
--
1.7.1
next prev parent reply other threads:[~2010-10-11 14:21 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-11 14:21 [PATCH 0/6] SD/MMC driver for MX25/35/51 Wolfram Sang
2010-10-11 14:21 ` [PATCH 1/6] mmc: sdhci-pltfm: Add structure for host-specific data Wolfram Sang
2010-10-11 14:21 ` [PATCH 2/6] mmc: sdhci-pltfm: move .h-file into apropriate subdir Wolfram Sang
2010-10-11 14:21 ` [PATCH 3/6] mmc: sdhci: introduce private get_ro Wolfram Sang
2010-10-11 14:21 ` Wolfram Sang [this message]
2010-10-11 14:21 ` [PATCH 5/6] mmc: sdhci-of-esdhc: factor out common stuff Wolfram Sang
2010-10-11 17:10 ` [PATCH v2 " Wolfram Sang
2010-10-11 18:33 ` Chris Ball
2010-10-13 10:22 ` Zhu Richard-R65037
2010-10-13 10:31 ` Wolfram Sang
2010-10-11 14:21 ` [PATCH 6/6] mmc: sdhci-pltfm: add pltfm-driver for imx35/51 Wolfram Sang
2010-10-14 3:07 ` Chris Ball
2010-10-11 16:32 ` [PATCH 0/6] SD/MMC driver for MX25/35/51 Chris Ball
2010-10-11 16:44 ` Wolfram Sang
2010-10-11 16:59 ` Chris Ball
2010-10-12 22:06 ` Arnaud Patard (Rtp)
2010-10-13 8:15 ` Eric Bénard
2010-10-13 8:29 ` Wolfram Sang
2010-10-13 9:28 ` Arnaud Patard (Rtp)
2010-10-13 9:53 ` Zhu Richard-R65037
2010-10-13 10:06 ` Wolfram Sang
2010-10-13 10:09 ` Eric Bénard
2010-10-13 10:13 ` Zhu Richard-R65037
2010-10-13 10:20 ` Wolfram Sang
2010-10-15 10:27 ` Wolfram Sang
2010-10-18 3:29 ` Zhu Richard-R65037
2010-10-18 8:48 ` Zhu Richard-R65037
2010-10-18 9:36 ` Eric Bénard
2010-10-18 9:44 ` Zhu Richard-R65037
2010-10-18 11:38 ` Wolfram Sang
2010-10-18 11:51 ` Eric Bénard
2010-10-18 11:36 ` Wolfram Sang
2010-10-15 10:25 ` Wolfram Sang
2010-10-15 21:20 ` Arnaud Patard (Rtp)
-- strict thread matches above, loose matches on Subject: below --
2010-10-15 10:20 [PATCH V5 " Wolfram Sang
2010-10-15 10:21 ` [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call Wolfram Sang
2010-09-29 20:07 [PATCH V3 0/6] SD/MMC-driver for MX35/51 (and improvements to SDHCI) Wolfram Sang
2010-09-29 20:08 ` [PATCH 4/6] mmc: sdhci_pltfm: pass more data on custom init-call Wolfram Sang
2010-09-30 8:31 ` Lothar Waßmann
2010-09-30 9:42 ` Anton Vorontsov
2010-10-11 11:07 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1286806866-19258-5-git-send-email-w.sang@pengutronix.de \
--to=w.sang@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).