* [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port
@ 2010-10-13 19:36 Mark Brown
2010-10-13 19:42 ` Mark Brown
2010-10-13 22:52 ` Kukjin Kim
0 siblings, 2 replies; 4+ messages in thread
From: Mark Brown @ 2010-10-13 19:36 UTC (permalink / raw)
To: linux-arm-kernel
When converting to use s3c_gpio_cfgpin_range() the function for the
IISv4 block appears to have been typoed as 4 (the keypad) rather than
5 as it should be.
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
arch/arm/mach-s3c64xx/dev-audio.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/dev-audio.c b/arch/arm/mach-s3c64xx/dev-audio.c
index e53764e..76426a3 100644
--- a/arch/arm/mach-s3c64xx/dev-audio.c
+++ b/arch/arm/mach-s3c64xx/dev-audio.c
@@ -49,7 +49,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device *pdev)
s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
- s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));
+ s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));
return 0;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port
2010-10-13 19:36 [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port Mark Brown
@ 2010-10-13 19:42 ` Mark Brown
2010-10-13 22:55 ` Kukjin Kim
2010-10-13 22:52 ` Kukjin Kim
1 sibling, 1 reply; 4+ messages in thread
From: Mark Brown @ 2010-10-13 19:42 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Oct 13, 2010 at 08:36:43PM +0100, Mark Brown wrote:
> When converting to use s3c_gpio_cfgpin_range() the function for the
> IISv4 block appears to have been typoed as 4 (the keypad) rather than
> 5 as it should be.
Sorry about the 2.6.36 in the subject line - this actually only applies
to -next.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port
2010-10-13 19:36 [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port Mark Brown
2010-10-13 19:42 ` Mark Brown
@ 2010-10-13 22:52 ` Kukjin Kim
1 sibling, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2010-10-13 22:52 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> When converting to use s3c_gpio_cfgpin_range() the function for the
> IISv4 block appears to have been typoed as 4 (the keypad) rather than
> 5 as it should be.
>
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> ---
> arch/arm/mach-s3c64xx/dev-audio.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/dev-audio.c
b/arch/arm/mach-s3c64xx/dev-
> audio.c
> index e53764e..76426a3 100644
> --- a/arch/arm/mach-s3c64xx/dev-audio.c
> +++ b/arch/arm/mach-s3c64xx/dev-audio.c
> @@ -49,7 +49,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device
> *pdev)
> s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
> s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
> s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
> - s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));
> + s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(5));
>
> return 0;
> }
> --
Hi,
According to commit f08269d8, when converting to use s3c_gpio_cfgpin_range()
the function, there was no typo.
(Commit f08269d8: ARM: S3C64XX: Change to using s3c_gpio_cfgpin_range())
@@ -51,10 +48,7 @@ static int s3c64xx_i2sv4_cfg_gpio(struct platform_device
*pdev)
s3c_gpio_cfgpin(S3C64XX_GPC(4), S3C_GPIO_SFN(5));
s3c_gpio_cfgpin(S3C64XX_GPC(5), S3C_GPIO_SFN(5));
s3c_gpio_cfgpin(S3C64XX_GPC(7), S3C_GPIO_SFN(5));
- s3c_gpio_cfgpin(S3C64XX_GPH(6), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(7), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(8), S3C_GPIO_SFN(4));
- s3c_gpio_cfgpin(S3C64XX_GPH(9), S3C_GPIO_SFN(4));
+ s3c_gpio_cfgpin_range(S3C64XX_GPH(6), 4, S3C_GPIO_SFN(4));
return 0;
}
It seems to happen more before...
Anyway, you're right. should be fixed.
Will apply in -next :-)
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port
2010-10-13 19:42 ` Mark Brown
@ 2010-10-13 22:55 ` Kukjin Kim
0 siblings, 0 replies; 4+ messages in thread
From: Kukjin Kim @ 2010-10-13 22:55 UTC (permalink / raw)
To: linux-arm-kernel
Mark Brown wrote:
>
> On Wed, Oct 13, 2010 at 08:36:43PM +0100, Mark Brown wrote:
> > When converting to use s3c_gpio_cfgpin_range() the function for the
> > IISv4 block appears to have been typoed as 4 (the keypad) rather than
> > 5 as it should be.
>
> Sorry about the 2.6.36 in the subject line - this actually only applies
> to -next.
No problem ;-)
Thanks for your fixing.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-10-13 22:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-13 19:36 [PATCH 2.6.36] S3C64XX: Fix special function for IISv4 port Mark Brown
2010-10-13 19:42 ` Mark Brown
2010-10-13 22:55 ` Kukjin Kim
2010-10-13 22:52 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).