From: h-kanigeri2@ti.com (Hari Kanigeri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/7] omap:mailbox: fix rx interrupt disable in omap4
Date: Thu, 14 Oct 2010 21:13:23 -0500 [thread overview]
Message-ID: <1287108808-32119-3-git-send-email-h-kanigeri2@ti.com> (raw)
In-Reply-To: <1287108808-32119-1-git-send-email-h-kanigeri2@ti.com>
disabling rx interrupt on omap4 is different than its pre-decessors.
The bit in OMAP4_MAILBOX_IRQENABLE_CLR should be set to disable the
interrupts instead of clearing the bit.
Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
---
arch/arm/mach-omap2/mailbox.c | 5 ++++-
1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/mailbox.c b/arch/arm/mach-omap2/mailbox.c
index 42dbfa4..82b5ced 100644
--- a/arch/arm/mach-omap2/mailbox.c
+++ b/arch/arm/mach-omap2/mailbox.c
@@ -195,7 +195,10 @@ static void omap2_mbox_disable_irq(struct omap_mbox *mbox,
struct omap_mbox2_priv *p = (struct omap_mbox2_priv *)mbox->priv;
u32 l, bit = (irq == IRQ_TX) ? p->notfull_bit : p->newmsg_bit;
l = mbox_read_reg(p->irqdisable);
- l &= ~bit;
+ if (cpu_is_omap44xx())
+ l |= bit;
+ else
+ l &= ~bit;
mbox_write_reg(l, p->irqdisable);
}
--
1.7.0
next prev parent reply other threads:[~2010-10-15 2:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-15 2:13 [PATCH 0/7] omap:mailbox-enhancements and fixes Hari Kanigeri
2010-10-15 2:13 ` [PATCH 1/7] mailbox: change full flag per mailbox queue instead of global Hari Kanigeri
2010-10-15 2:13 ` Hari Kanigeri [this message]
2010-10-15 2:13 ` [PATCH 3/7] omap:mailbox-fix checkpatch warnings Hari Kanigeri
2010-10-15 2:13 ` [PATCH 4/7] omap:mailbox-send message in process context Hari Kanigeri
2010-10-21 19:03 ` Sapiens, Rene
2010-10-21 20:49 ` Hari Kanigeri
2010-10-21 22:30 ` Sapiens, Rene
2010-10-15 2:13 ` [PATCH 5/7] omap:mailbox-resolve multiple receiver problem Hari Kanigeri
2010-10-28 22:18 ` Omar Ramirez Luna
2010-10-29 12:10 ` Hari Kanigeri
2010-10-15 2:13 ` [PATCH 6/7] omap:mailbox-add notification support for multiple readers Hari Kanigeri
2010-10-28 20:57 ` Omar Ramirez Luna
2010-10-29 12:05 ` Hari Kanigeri
2010-10-15 2:13 ` [PATCH 7/7] omap:clocks44x-add dummy clock for mailbox Hari Kanigeri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287108808-32119-3-git-send-email-h-kanigeri2@ti.com \
--to=h-kanigeri2@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox