Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: guenter.roeck@ericsson.com (Guenter Roeck)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] hwmon: add generic GPIO fan driver
Date: Thu, 21 Oct 2010 18:51:41 -0700	[thread overview]
Message-ID: <1287712301.9690.376.camel@groeck-laptop> (raw)
In-Reply-To: <1287701059-2226-1-git-send-email-simon@sequanux.org>

Hi Simon,

On Thu, 2010-10-21 at 18:44 -0400, Simon Guinot wrote:
> From: Simon Guinot <sguinot@lacie.com>
> 
> This patch adds hwmon support for the GPIO connected fan.
> 
I rephrased this to ".. for fans connected to GPIO pins."

> Platform specific informations as GPIO pinout and speed conversion array
> (rpm from/to GPIO value) are passed to the driver via platform_data.
> 
> Signed-off-by: Simon Guinot <sguinot@lacie.com>

[ ... ]
> +static int __devinit gpio_fan_probe(struct platform_device *pdev)
> +{
> +       int err = 0;

and this variable initialization is not needed.

Otherwise looks good. Applied with the above changed to my -next tree.

I'll let it rest there for a couple of days. Unless some unforeseen
problems show up, it might just make it into .37.

Thanks,
Guenter

  reply	other threads:[~2010-10-22  1:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-10-20 16:37 [PATCH v2] hwmon: add generic GPIO fan driver Simon Guinot
2010-10-20 16:37 ` Simon Guinot
2010-10-20 16:59   ` Guenter Roeck
2010-10-20 19:10     ` Simon Guinot
2010-10-20 20:42       ` Guenter Roeck
2010-10-20 19:18     ` Russell King - ARM Linux
2010-10-20 20:06       ` Guenter Roeck
2010-10-21  6:41   ` Guenter Roeck
2010-10-21 14:06     ` Simon Guinot
2010-10-21 14:43       ` Guenter Roeck
2010-10-21 21:59         ` [lm-sensors] " Simon Guinot
2010-10-21 22:16           ` Guenter Roeck
2010-10-21 22:35             ` Simon Guinot
2010-10-21 22:44               ` [PATCH v3] " Simon Guinot
2010-10-22  1:51                 ` Guenter Roeck [this message]
2010-10-22 12:25                   ` Simon Guinot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1287712301.9690.376.camel@groeck-laptop \
    --to=guenter.roeck@ericsson.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox