From: eric@eukrea.com (Eric Bénard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/2] sdhci-esdhc-imx: fix timeout on i.MX's sdhci
Date: Fri, 22 Oct 2010 10:46:18 +0200 [thread overview]
Message-ID: <1287737179-3956-1-git-send-email-eric@eukrea.com> (raw)
In-Reply-To: <20101022061803.GB5572@pengutronix.de>
this patch fix timeout problems on i.MX's sdhci as suggested by
Richard Zhu.
Tested on :
- i.MX257 : not needed
- i.MX357 : needed
- i.MX515 : needed
more details can be found here :
http://lists.infradead.org/pipermail/linux-arm-kernel/2010-October/029748.html
Signed-off-by: Eric B?nard <eric@eukrea.com>
Tested-by: Shawn Guo <shawn.gsc@gmail.com>
Acked-by: Wolfram Sang <w.sang@pengutronix.de>
---
drivers/mmc/host/sdhci-esdhc-imx.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index afbac9a..31256ad 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -130,6 +130,10 @@ static int esdhc_pltfm_init(struct sdhci_host *host, struct sdhci_pltfm_data *pd
gpio_request(boarddata->wp_gpio, "SD_WP");
gpio_direction_input(boarddata->wp_gpio);
}
+
+ if (cpu_is_mx35() || cpu_is_mx51())
+ host->quirks |= SDHCI_QUIRK_BROKEN_TIMEOUT_VAL;
+
return 0;
}
--
1.7.0.4
next prev parent reply other threads:[~2010-10-22 8:46 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-20 8:53 [PATCH 0/2] babbage: support mmc device Shawn Guo
2010-10-20 9:22 ` [PATCH 1/2] mmc: quirk fix for timeout problem Shawn Guo
2010-10-20 11:27 ` Wolfram Sang
2010-10-21 16:11 ` Shawn Guo
2010-10-21 16:43 ` Wolfram Sang
2010-10-21 17:10 ` Nicolas Pitre
2010-10-21 18:14 ` Shawn Guo
2010-10-21 20:28 ` Eric Bénard
2010-10-21 21:20 ` [PATCH 1/2] sdhci-esdhc-imx: fix timeout on i.MX's sdhci Eric Bénard
2010-10-22 6:15 ` Wolfram Sang
2010-10-22 23:12 ` Chris Ball
2010-10-22 23:57 ` Eric Bénard
2010-11-07 22:51 ` Chris Ball
2010-10-22 23:57 ` [PATCH 2/2] sdhci-esdhc-imx: enable QUIRK_NO_MULTIBLOCK only for i.MX25 and i.MX35 Eric Bénard
2010-10-21 21:20 ` Eric Bénard
2010-10-22 6:18 ` Wolfram Sang
2010-10-22 7:07 ` Eric Bénard
2010-10-22 8:46 ` Eric Bénard [this message]
2010-10-22 8:46 ` [PATCH v2 " Eric Bénard
2010-10-22 10:54 ` Wolfram Sang
2010-10-22 4:39 ` [PATCH 1/2] mmc: quirk fix for timeout problem Shawn Guo
2010-10-20 9:24 ` [PATCH 2/2] babbage: esdhc device registration Shawn Guo
2010-10-20 11:30 ` Wolfram Sang
2010-10-20 11:52 ` Amit Kucheria
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287737179-3956-1-git-send-email-eric@eukrea.com \
--to=eric@eukrea.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).