From: radoslav.kolev@rnd.bg (Radoslav Kolev)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mx3: Enable PWM clock on mx31 and mx35
Date: Fri, 22 Oct 2010 15:26:17 +0300 [thread overview]
Message-ID: <1287750377.2441.5.camel@rado-desktop> (raw)
In-Reply-To: <4CC17DA2.6020601@eukrea.com>
On Fri, 2010-10-22 at 14:03 +0200, Eric B?nard wrote:
> Hi Fabio,
>
> Le 22/10/2010 13:13, Fabio Estevam a ?crit :
> > mx3: Enable PWM clock on mx31 and mx35.
> >
> Are you sure this in needed as when using the pwm.c driver in plat-mxc there
> are pwm_enable and pwm_disable functions ?
>
> With your patch, platforms without PWM will have the pwm clock enabled.
Fabio, sorry if I have mislead you.
I wasn't properly using the plat-mxc/pwm.c driver (and hence the
enable/disable functions were not getting called). I was just mucking
about with the registers directly, first from userspace and then by
putting some code in the driver probe function. So it was really strange
for me that I couldn't do any writes.
If the plat-mxc/pwm.c driver is used properly I guess this patch won't
be needed.
Regards,
Radoslav Kolev
prev parent reply other threads:[~2010-10-22 12:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-22 11:13 [PATCH] mx3: Enable PWM clock on mx31 and mx35 Fabio Estevam
2010-10-22 12:03 ` Eric Bénard
2010-10-22 12:26 ` Radoslav Kolev [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287750377.2441.5.camel@rado-desktop \
--to=radoslav.kolev@rnd.bg \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).