* [PATCH] mach-pcm037_eet: Fix section mismatch for eet_init_devices()
@ 2010-11-01 17:00 Alberto Panizzo
2010-11-05 14:00 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Alberto Panizzo @ 2010-11-01 17:00 UTC (permalink / raw)
To: linux-arm-kernel
This function should be marked as __init because it is used only
in the init phase.
This fix the compiler warning:
LD arch/arm/mach-mx3/built-in.o
WARNING: arch/arm/mach-mx3/built-in.o(.text+0x1328): Section mismatch in reference from the function eet_init_devices() to the (unknown reference) .init.rodata:(unknown)
The function eet_init_devices() references
the (unknown reference) __initconst (unknown).
This is often because eet_init_devices lacks a __initconst
annotation or the annotation of (unknown) is wrong.
Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
---
arch/arm/mach-mx3/mach-pcm037_eet.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx3/mach-pcm037_eet.c b/arch/arm/mach-mx3/mach-pcm037_eet.c
index 99e0894..3392812 100644
--- a/arch/arm/mach-mx3/mach-pcm037_eet.c
+++ b/arch/arm/mach-mx3/mach-pcm037_eet.c
@@ -171,7 +171,7 @@ static struct platform_device pcm037_gpio_keys_device = {
},
};
-static int eet_init_devices(void)
+static int __init eet_init_devices(void)
{
if (!machine_is_pcm037() || pcm037_variant() != PCM037_EET)
return 0;
--
1.6.3.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] mach-pcm037_eet: Fix section mismatch for eet_init_devices()
2010-11-01 17:00 [PATCH] mach-pcm037_eet: Fix section mismatch for eet_init_devices() Alberto Panizzo
@ 2010-11-05 14:00 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2010-11-05 14:00 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 01, 2010 at 06:00:03PM +0100, Alberto Panizzo wrote:
> This function should be marked as __init because it is used only
> in the init phase.
>
> This fix the compiler warning:
> LD arch/arm/mach-mx3/built-in.o
> WARNING: arch/arm/mach-mx3/built-in.o(.text+0x1328): Section mismatch in reference from the function eet_init_devices() to the (unknown reference) .init.rodata:(unknown)
> The function eet_init_devices() references
> the (unknown reference) __initconst (unknown).
> This is often because eet_init_devices lacks a __initconst
> annotation or the annotation of (unknown) is wrong.
>
> Signed-off-by: Alberto Panizzo <maramaopercheseimorto@gmail.com>
Acked-by: Uwe Kleine-K?nig <u.kleine-koenig@pengutronix.de>
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-05 14:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-01 17:00 [PATCH] mach-pcm037_eet: Fix section mismatch for eet_init_devices() Alberto Panizzo
2010-11-05 14:00 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).