From mboxrd@z Thu Jan 1 00:00:00 1970 From: khilman@deeprootsystems.com (Kevin Hilman) Date: Thu, 04 Nov 2010 11:48:20 -0400 Subject: [PATCH v3 06/13] OMAP3: DMA: hwmod: add system DMA In-Reply-To: <4CD2A765.404@ti.com> References: <1288099513-1854-1-git-send-email-manjugk@ti.com> <1288099513-1854-7-git-send-email-manjugk@ti.com> <4CD2368D.50107@ti.com> <4CD2A765.404@ti.com> Message-ID: <1288885700.27306.22.camel@localhost> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Thu, 2010-11-04 at 08:30 -0400, Cousson, Benoit wrote: [...] > >>> Any better suggestion to handle this issue? > >> > >> Well, yes, use HWMOD_NO_IDLEST and remove idlest_reg_id& > >> idlest_idle_bit entries in the omap2 structure. > >> > >> ST_SDMA is the standby status of the SDMA, but there is no > >> idle status > >> on that IP, so you cannot do anything. > >> The standby will just reflect the activity of the master port of > the > >> DMA, but it will give you no information about the slave port > >> and thus > >> we do not have any module ready information. > > > > Thanks for the feedback. > > > > This change is introduced as per kevin's review comment at: > > http://www.mail-archive.com/linux-omap at vger.kernel.org/msg34278.html > > Well this register is confusing, because he uses the same naming > convention but with a difference meaning: > > ST_SDMA: System DMA standby status. > - 0x0: System DMA is active. > - 0x1: System DMA is in standby mode. > > > I am ok to use "HWMOD_NO_IDLEST" if kevin also agrees I agree. > He will... Otherwise I will throw him into the New England Aquarium > like Linus :-) ...if he tried, I think he would end up in the fish tank before me. ;) Kevin