From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
Date: Mon, 08 Nov 2010 09:39:43 -0800 [thread overview]
Message-ID: <1289237983.29216.340.camel@Joe-Laptop> (raw)
In-Reply-To: <20101108081808.GN16938@pengutronix.de>
On Mon, 2010-11-08 at 09:18 +0100, Uwe Kleine-K?nig wrote:
> On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> > diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
[]
> > - printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> > - with error code %d\n", __func__, ret);
> > + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> > + __func__, ret);
> I'd prefer
> + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
> + "with error code %d\n", __func__, ret);
> (actually I'd consider
> + pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)
> even better, but this is out of scope for this patch, isn't it?)
Yes, it's out of scope.
I do have a perl & emacs script that converts
printk(KERN_<level> to pr_<level>, coalesces formats,
and wraps/aligns arguments.
It's around 2K lines of changes though for arch/arm.
Anyone want that all at once or by platform by platform?
prev parent reply other threads:[~2010-11-08 17:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-07 21:10 [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect Joe Perches
2010-11-08 8:18 ` Uwe Kleine-König
2010-11-08 9:08 ` Russell King - ARM Linux
2010-11-08 17:39 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289237983.29216.340.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox