* [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
@ 2010-11-07 21:10 Joe Perches
2010-11-08 8:18 ` Uwe Kleine-König
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2010-11-07 21:10 UTC (permalink / raw)
To: linux-arm-kernel
Signed-off-by: Joe Perches <joe@perches.com>
---
arch/arm/plat-mxc/cpufreq.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
index 039538e..9f358af 100644
--- a/arch/arm/plat-mxc/cpufreq.c
+++ b/arch/arm/plat-mxc/cpufreq.c
@@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
if (ret < 0) {
- printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
- with error code %d\n", __func__, ret);
+ printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
+ __func__, ret);
goto err;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
2010-11-07 21:10 [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect Joe Perches
@ 2010-11-08 8:18 ` Uwe Kleine-König
2010-11-08 9:08 ` Russell King - ARM Linux
2010-11-08 17:39 ` Joe Perches
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2010-11-08 8:18 UTC (permalink / raw)
To: linux-arm-kernel
Hi Joe,
On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@perches.com>
> ---
> arch/arm/plat-mxc/cpufreq.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
> index 039538e..9f358af 100644
> --- a/arch/arm/plat-mxc/cpufreq.c
> +++ b/arch/arm/plat-mxc/cpufreq.c
> @@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
> ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
>
> if (ret < 0) {
> - printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> - with error code %d\n", __func__, ret);
> + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> + __func__, ret);
I'd prefer
+ printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
+ "with error code %d\n", __func__, ret);
(actually I'd consider
+ pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)
even better, but this is out of scope for this patch, isn't it?)
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
2010-11-08 8:18 ` Uwe Kleine-König
@ 2010-11-08 9:08 ` Russell King - ARM Linux
2010-11-08 17:39 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Russell King - ARM Linux @ 2010-11-08 9:08 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, Nov 08, 2010 at 09:18:08AM +0100, Uwe Kleine-K?nig wrote:
> Hi Joe,
>
> On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > arch/arm/plat-mxc/cpufreq.c | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
> > index 039538e..9f358af 100644
> > --- a/arch/arm/plat-mxc/cpufreq.c
> > +++ b/arch/arm/plat-mxc/cpufreq.c
> > @@ -154,8 +154,8 @@ static int __init mxc_cpufreq_init(struct cpufreq_policy *policy)
> > ret = cpufreq_frequency_table_cpuinfo(policy, imx_freq_table);
> >
> > if (ret < 0) {
> > - printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> > - with error code %d\n", __func__, ret);
> > + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> > + __func__, ret);
> I'd prefer
> + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
> + "with error code %d\n", __func__, ret);
No - you don't wrap error messages. It's the one exception to the 80
column rule.
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect
2010-11-08 8:18 ` Uwe Kleine-König
2010-11-08 9:08 ` Russell King - ARM Linux
@ 2010-11-08 17:39 ` Joe Perches
1 sibling, 0 replies; 4+ messages in thread
From: Joe Perches @ 2010-11-08 17:39 UTC (permalink / raw)
To: linux-arm-kernel
On Mon, 2010-11-08 at 09:18 +0100, Uwe Kleine-K?nig wrote:
> On Sun, Nov 07, 2010 at 01:10:15PM -0800, Joe Perches wrote:
> > diff --git a/arch/arm/plat-mxc/cpufreq.c b/arch/arm/plat-mxc/cpufreq.c
[]
> > - printk(KERN_ERR "%s: failed to register i.MXC CPUfreq \
> > - with error code %d\n", __func__, ret);
> > + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq with error code %d\n",
> > + __func__, ret);
> I'd prefer
> + printk(KERN_ERR "%s: failed to register i.MXC CPUfreq "
> + "with error code %d\n", __func__, ret);
> (actually I'd consider
> + pr_err("failed to register i.MXC CPUfreq (error: %d)\n", ret)
> even better, but this is out of scope for this patch, isn't it?)
Yes, it's out of scope.
I do have a perl & emacs script that converts
printk(KERN_<level> to pr_<level>, coalesces formats,
and wraps/aligns arguments.
It's around 2K lines of changes though for arch/arm.
Anyone want that all at once or by platform by platform?
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2010-11-08 17:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-07 21:10 [PATCH] arch/arm/plat-mxc/cpufreq.c: Fix line continuation defect Joe Perches
2010-11-08 8:18 ` Uwe Kleine-König
2010-11-08 9:08 ` Russell King - ARM Linux
2010-11-08 17:39 ` Joe Perches
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox