From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] msm: smd: Reduce driver log chatter
Date: Thu, 11 Nov 2010 20:22:54 -0800 [thread overview]
Message-ID: <1289535774.6519.54.camel@Joe-Laptop> (raw)
In-Reply-To: <1289516079-24632-1-git-send-email-davidb@codeaurora.org>
On Thu, 2010-11-11 at 14:54 -0800, David Brown wrote:
> The MSM smd driver logs numerous messages during startup that are
> useful for debug purposes. Change some of these to pr_debug() to
> match their purpose, and remove others that aren't really useful.
Hi David.
> arch/arm/mach-msm/smd.c | 17 +++++++----------
> @@ -725,7 +727,7 @@ int smd_close(smd_channel_t *ch)
> {
> unsigned long flags;
>
> - pr_info("smd_close(%p)\n", ch);
> + pr_debug("smd_close(%p)\n", ch);
Why keep a printk for close without a printk for open?
I suggest removing this one too.
next prev parent reply other threads:[~2010-11-12 4:22 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-10 0:30 [PATCH] msm: smd: Reduce driver log chatter David Brown
2010-11-10 0:49 ` [PATCH v2] " David Brown
2010-11-10 0:56 ` Joe Perches
2010-11-10 17:59 ` [PATCH v3] " David Brown
2010-11-10 18:24 ` Joe Perches
2010-11-10 18:34 ` Brian Swetland
2010-11-11 22:54 ` [PATCH v4] " David Brown
2010-11-12 4:22 ` Joe Perches [this message]
2010-11-12 21:49 ` [PATCH v5] " David Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289535774.6519.54.camel@Joe-Laptop \
--to=joe@perches.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox