From: catalin.marinas@arm.com (Catalin Marinas)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in kernel/head.S
Date: Wed, 17 Nov 2010 10:16:40 +0000 [thread overview]
Message-ID: <1289989000.2351.13.camel@e102109-lin.cambridge.arm.com> (raw)
In-Reply-To: <20101116182257.GB21926@n2100.arm.linux.org.uk>
On Tue, 2010-11-16 at 18:22 +0000, Russell King - ARM Linux wrote:
> On Tue, Nov 16, 2010 at 01:14:34PM +0000, Dave Martin wrote:
> > Directives such as .long and .word do not magically cause the
> > assembler location counter to become aligned in gas. As a
> > result, using these directives in code sections can result in
> > misaligned data words when building a Thumb-2 kernel
> > (CONFIG_THUMB2_KERNEL).
>
> > @@ -413,6 +416,7 @@ __fixup_smp_on_up:
> > mov pc, lr
> > ENDPROC(__fixup_smp)
> >
> > + .align
> > 1: .word .
> > .word __smpalt_begin
> > .word __smpalt_end
>
> This one is technically bogus because this feature is disabled (and
> incompatible) with Thumb-2 kernels. So it never gets built for a T2
> kernel.
Well, I think it doesn't cause any harm to have it in. It's on our to-do
list to allow T2 support for SMP-on-UP.
--
Catalin
next prev parent reply other threads:[~2010-11-17 10:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-16 13:14 [PATCH 1/7] ARM: kexec: Correct data alignment for CONFIG_THUMB2_KERNEL Dave Martin
2010-11-16 13:14 ` [PATCH 2/7] ARM: vfp: " Dave Martin
2010-11-16 13:14 ` [PATCH 3/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in bootp/init.S Dave Martin
2010-11-16 13:14 ` [PATCH 4/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in kernel/head.S Dave Martin
2010-11-16 18:22 ` Russell King - ARM Linux
2010-11-17 10:16 ` Catalin Marinas [this message]
2010-11-17 10:16 ` Dave Martin
2010-11-16 13:14 ` [PATCH 5/7] ARM: Thumb-2: Correct data alignment for CONFIG_THUMB2_KERNEL in mm/proc-v7.S Dave Martin
2010-11-16 13:14 ` [PATCH 6/7] ARM: Thumb-2: Fix CONFIG_THUMB2_KERNEL breakage in compressed/head.S Dave Martin
2010-11-16 13:14 ` [PATCH 7/7] ARM: Thumb-2: Restore sensible zImage header layout for CONFIG_THUMB2_KERNEL Dave Martin
2010-11-16 18:26 ` Russell King - ARM Linux
2010-11-16 20:28 ` Nicolas Pitre
2010-11-16 20:35 ` Russell King - ARM Linux
2010-11-16 20:58 ` Uwe Kleine-König
2010-11-17 9:16 ` Dave Martin
2010-11-17 9:19 ` Dave Martin
2010-11-17 10:21 ` Catalin Marinas
2010-11-17 11:11 ` [PATCH 7/7 v1.1] " Dave Martin
2010-11-17 16:17 ` Nicolas Pitre
2010-11-17 16:46 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289989000.2351.13.camel@e102109-lin.cambridge.arm.com \
--to=catalin.marinas@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).