From: h-kanigeri2@ti.com (Hari Kanigeri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/5] OMAP: mailbox: send message in process context
Date: Thu, 18 Nov 2010 13:15:41 -0600 [thread overview]
Message-ID: <1290107742-16760-5-git-send-email-h-kanigeri2@ti.com> (raw)
In-Reply-To: <1290107742-16760-1-git-send-email-h-kanigeri2@ti.com>
Schedule the Tasklet to send only when mailbox fifo is full and there are
pending messages in kifo, else send the message directly in the Process
context. This would avoid needless scheduling of Tasklet for every message
transfer
Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
---
arch/arm/plat-omap/mailbox.c | 9 +++++++--
1 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index abfc495..b14bc34 100644
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -92,20 +92,25 @@ int omap_mbox_msg_send(struct omap_mbox *mbox, mbox_msg_t msg)
struct omap_mbox_queue *mq = mbox->txq;
int ret = 0, len;
- spin_lock(&mq->lock);
+ spin_lock_bh(&mq->lock);
if (kfifo_avail(&mq->fifo) < sizeof(msg)) {
ret = -ENOMEM;
goto out;
}
+ if (kfifo_is_empty(&mq->fifo) && !__mbox_poll_for_space(mbox)) {
+ mbox_fifo_write(mbox, msg);
+ goto out;
+ }
+
len = kfifo_in(&mq->fifo, (unsigned char *)&msg, sizeof(msg));
WARN_ON(len != sizeof(msg));
tasklet_schedule(&mbox->txq->tasklet);
out:
- spin_unlock(&mq->lock);
+ spin_unlock_bh(&mq->lock);
return ret;
}
EXPORT_SYMBOL(omap_mbox_msg_send);
--
1.7.0
next prev parent reply other threads:[~2010-11-18 19:15 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-18 19:15 [PATCH v3 0/5] OMAP: mailbox: enhancements and fixes Hari Kanigeri
2010-11-18 19:15 ` [PATCH v3 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global Hari Kanigeri
2010-11-18 23:22 ` Cousson, Benoit
2010-11-18 19:15 ` [PATCH v3 2/5] OMAP: mailbox: fix rx interrupt disable in omap4 Hari Kanigeri
2010-11-18 23:28 ` Cousson, Benoit
2010-11-19 0:07 ` Kanigeri, Hari
2010-11-19 8:32 ` Felipe Balbi
2010-11-19 14:22 ` Kanigeri, Hari
2010-11-19 14:50 ` Cousson, Benoit
2010-11-22 10:08 ` Felipe Balbi
2010-11-22 11:46 ` Kanigeri, Hari
2010-11-22 11:51 ` Felipe Balbi
2010-11-22 11:58 ` Kanigeri, Hari
2010-11-22 14:57 ` Cousson, Benoit
2010-11-22 14:55 ` Cousson, Benoit
2010-11-23 8:10 ` Felipe Balbi
2010-11-19 8:32 ` Felipe Balbi
2010-11-18 19:15 ` [PATCH v3 3/5] OMAP: mailbox: fix checkpatch warnings Hari Kanigeri
2010-11-19 8:33 ` Felipe Balbi
2010-11-19 11:52 ` Kanigeri, Hari
2010-11-18 19:15 ` Hari Kanigeri [this message]
2010-11-19 8:34 ` [PATCH v3 4/5] OMAP: mailbox: send message in process context Felipe Balbi
2010-11-18 19:15 ` [PATCH v3 5/5] OMAP: mailbox: add notification support for multiple readers Hari Kanigeri
2010-11-19 8:50 ` Felipe Balbi
2010-11-19 11:50 ` Kanigeri, Hari
2010-11-19 12:09 ` Felipe Balbi
2010-11-19 12:29 ` Kanigeri, Hari
2010-11-19 12:53 ` Felipe Balbi
2010-11-19 13:57 ` Kanigeri, Hari
2010-11-19 14:25 ` Felipe Balbi
2010-11-19 14:44 ` Kanigeri, Hari
2010-11-19 23:07 ` Felipe Balbi
2010-11-20 4:01 ` Kanigeri, Hari
2010-11-20 11:31 ` Felipe Balbi
2010-11-20 13:26 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290107742-16760-5-git-send-email-h-kanigeri2@ti.com \
--to=h-kanigeri2@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).