From mboxrd@z Thu Jan 1 00:00:00 1970 From: catalin.marinas@arm.com (Catalin Marinas) Date: Tue, 23 Nov 2010 17:35:29 +0000 Subject: [PATCH v2 08/20] ARM: LPAE: MMU setup for the 3-level page table format In-Reply-To: <20101123173319.GA26510@n2100.arm.linux.org.uk> References: <1289584840-18097-1-git-send-email-catalin.marinas@arm.com> <1289584840-18097-9-git-send-email-catalin.marinas@arm.com> <20101122131010.GD31227@n2100.arm.linux.org.uk> <20101123173319.GA26510@n2100.arm.linux.org.uk> Message-ID: <1290533729.6381.128.camel@e102109-lin.cambridge.arm.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, 2010-11-23 at 17:33 +0000, Russell King - ARM Linux wrote: > On Tue, Nov 23, 2010 at 11:38:15AM +0000, Catalin Marinas wrote: > > On 22 November 2010 13:10, Russell King - ARM Linux > > wrote: > > > Are you sure these shifts by 18 places are correct? They're actually > > > (val >> SECTION_SHIFT) << 2, so maybe they should be (SECTION_SHIFT - > > > PMD_WORDS) ? > > > > SECTION_SHIFT - PMD_ORDER is (20 - 2) for classic page tables and (21 > > - 3) for LPAE. But we could change the 18 to some macros for > > clarification (the line would be long though). > > So yes, it's SECTION_SHIFT - PMD_ORDER, which is how they should be > used IMHO. I don't see why another macro would be necessary. I didn't mean adding another macro but using (SECTION_SHIFT - PMD_ORDER) on a long line. -- Catalin