From: h-kanigeri2@ti.com (Hari Kanigeri)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global
Date: Tue, 23 Nov 2010 15:26:53 -0600 [thread overview]
Message-ID: <1290547617-16640-2-git-send-email-h-kanigeri2@ti.com> (raw)
In-Reply-To: <1290547617-16640-1-git-send-email-h-kanigeri2@ti.com>
From: Fernando Guzman Lugo <x0095840@ti.com>
The variable rq_full flag is a global variable, so if there are multiple
mailbox users there will be conflicts. Now there is a full flag per
mailbox queue.
Reported-by: Ohad Ben-Cohen <ohad@wizery.com>
Signed-off-by: Fernando Guzman Lugo <x0095840@ti.com>
Signed-off-by: Hari Kanigeri <h-kanigeri2@ti.com>
---
arch/arm/plat-omap/include/plat/mailbox.h | 1 +
arch/arm/plat-omap/mailbox.c | 9 +++++++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/include/plat/mailbox.h b/arch/arm/plat-omap/include/plat/mailbox.h
index 9976565..13f2ef3 100644
--- a/arch/arm/plat-omap/include/plat/mailbox.h
+++ b/arch/arm/plat-omap/include/plat/mailbox.h
@@ -48,6 +48,7 @@ struct omap_mbox_queue {
struct tasklet_struct tasklet;
int (*callback)(void *);
struct omap_mbox *mbox;
+ bool full;
};
struct omap_mbox {
diff --git a/arch/arm/plat-omap/mailbox.c b/arch/arm/plat-omap/mailbox.c
index d2fafb8..48e161c 100644
--- a/arch/arm/plat-omap/mailbox.c
+++ b/arch/arm/plat-omap/mailbox.c
@@ -33,7 +33,6 @@
static struct workqueue_struct *mboxd;
static struct omap_mbox **mboxes;
-static bool rq_full;
static int mbox_configured;
static DEFINE_MUTEX(mbox_configured_lock);
@@ -148,6 +147,12 @@ static void mbox_rx_work(struct work_struct *work)
if (mq->callback)
mq->callback((void *)msg);
+ spin_lock_irq(&mq->lock);
+ if (mq->full) {
+ mq->full = false;
+ omap_mbox_enable_irq(mq->mbox, IRQ_RX);
+ }
+ spin_unlock_irq(&mq->lock);
}
}
@@ -170,7 +175,7 @@ static void __mbox_rx_interrupt(struct omap_mbox *mbox)
while (!mbox_fifo_empty(mbox)) {
if (unlikely(kfifo_avail(&mq->fifo) < sizeof(msg))) {
omap_mbox_disable_irq(mbox, IRQ_RX);
- rq_full = true;
+ mq->full = true;
goto nomem;
}
--
1.7.0
next prev parent reply other threads:[~2010-11-23 21:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-23 21:26 [PATCH v4 0/5] OMAP: mailbox: fixes and enhancements Hari Kanigeri
2010-11-23 21:26 ` Hari Kanigeri [this message]
2010-11-24 5:21 ` [PATCH v4 1/5] OMAP: mailbox: change full flag per mailbox queue instead of global Varadarajan, Charulatha
2010-11-24 12:47 ` Kanigeri, Hari
2010-11-24 13:04 ` Varadarajan, Charulatha
2010-11-23 21:26 ` [PATCH v4 2/5] OMAP: mailbox: fix rx interrupt disable in omap4 Hari Kanigeri
2010-11-24 5:16 ` Varadarajan, Charulatha
2010-11-24 8:22 ` Felipe Balbi
2010-11-24 8:50 ` Varadarajan, Charulatha
2010-11-24 8:53 ` Felipe Balbi
2010-11-24 13:01 ` Kanigeri, Hari
2010-11-25 7:04 ` Varadarajan, Charulatha
2010-11-25 14:03 ` Hari Kanigeri
2010-11-23 21:26 ` [PATCH v4 3/5] OMAP: mailbox: fix checkpatch warnings Hari Kanigeri
2010-11-23 21:26 ` [PATCH v4 4/5] OMAP: mailbox: send message in process context Hari Kanigeri
2010-11-24 5:26 ` Varadarajan, Charulatha
2010-11-24 13:14 ` Kanigeri, Hari
2010-11-23 21:26 ` [PATCH v4 5/5] OMAP: mailbox: add notification support for multiple readers Hari Kanigeri
2010-11-24 5:29 ` Varadarajan, Charulatha
2010-11-24 13:09 ` Kanigeri, Hari
2010-11-24 13:12 ` Varadarajan, Charulatha
2010-11-24 13:22 ` Kanigeri, Hari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1290547617-16640-2-git-send-email-h-kanigeri2@ti.com \
--to=h-kanigeri2@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).