* [PATCH] arm: omap2: io: fix clk_get() error check
@ 2010-11-30 14:17 Aaro Koskinen
2010-12-02 10:11 ` Kevin Hilman
0 siblings, 1 reply; 3+ messages in thread
From: Aaro Koskinen @ 2010-11-30 14:17 UTC (permalink / raw)
To: linux-arm-kernel
clk_get() return value should be checked with IS_ERR().
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
arch/arm/mach-omap2/io.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
index 40562dd..a1939b1 100644
--- a/arch/arm/mach-omap2/io.c
+++ b/arch/arm/mach-omap2/io.c
@@ -297,7 +297,7 @@ static int __init _omap2_init_reprogram_sdrc(void)
return 0;
dpll3_m2_ck = clk_get(NULL, "dpll3_m2_ck");
- if (!dpll3_m2_ck)
+ if (IS_ERR(dpll3_m2_ck))
return -EINVAL;
rate = clk_get_rate(dpll3_m2_ck);
--
1.5.6.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] arm: omap2: io: fix clk_get() error check
2010-11-30 14:17 [PATCH] arm: omap2: io: fix clk_get() error check Aaro Koskinen
@ 2010-12-02 10:11 ` Kevin Hilman
2010-12-03 1:10 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Kevin Hilman @ 2010-12-02 10:11 UTC (permalink / raw)
To: linux-arm-kernel
Aaro Koskinen <aaro.koskinen@nokia.com> writes:
> clk_get() return value should be checked with IS_ERR().
>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
Acked-by: Kevin Hilman <khilman@deeprootsystems.com>
> ---
> arch/arm/mach-omap2/io.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/io.c b/arch/arm/mach-omap2/io.c
> index 40562dd..a1939b1 100644
> --- a/arch/arm/mach-omap2/io.c
> +++ b/arch/arm/mach-omap2/io.c
> @@ -297,7 +297,7 @@ static int __init _omap2_init_reprogram_sdrc(void)
> return 0;
>
> dpll3_m2_ck = clk_get(NULL, "dpll3_m2_ck");
> - if (!dpll3_m2_ck)
> + if (IS_ERR(dpll3_m2_ck))
> return -EINVAL;
>
> rate = clk_get_rate(dpll3_m2_ck);
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-03 1:10 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-30 14:17 [PATCH] arm: omap2: io: fix clk_get() error check Aaro Koskinen
2010-12-02 10:11 ` Kevin Hilman
2010-12-03 1:10 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).