* [PATCH] ARM: mx5: fix keypad clock
@ 2010-11-30 17:19 Fabio Estevam
2010-11-30 18:22 ` Uwe Kleine-König
0 siblings, 1 reply; 2+ messages in thread
From: Fabio Estevam @ 2010-11-30 17:19 UTC (permalink / raw)
To: linux-arm-kernel
This fixes the following error during keypad driver probe:
imx-keypad imx-keypad: failed to get keypad clock
imx-keypad: probe of imx-keypad failed with error -2
Register keypad clock the same way as other imx platforms.
Tested keypad succesfully on a MX51_3DS board.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/clock-mx51-mx53.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
index 344ee8e..86fa0f4 100644
--- a/arch/arm/mach-mx5/clock-mx51-mx53.c
+++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
@@ -1091,7 +1091,7 @@ static struct clk_lookup mx51_lookups[] = {
_REGISTER_CLOCK("mxc-ehci.1", "usb_ahb", ahb_clk)
_REGISTER_CLOCK("fsl-usb2-udc", "usb", usboh3_clk)
_REGISTER_CLOCK("fsl-usb2-udc", "usb_ahb", ahb_clk)
- _REGISTER_CLOCK("imx-keypad.0", NULL, kpp_clk)
+ _REGISTER_CLOCK(NULL, "kpp", kpp_clk)
_REGISTER_CLOCK("mxc_nand", NULL, nfc_clk)
_REGISTER_CLOCK("imx-ssi.0", NULL, ssi1_clk)
_REGISTER_CLOCK("imx-ssi.1", NULL, ssi2_clk)
--
1.6.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [PATCH] ARM: mx5: fix keypad clock
2010-11-30 17:19 [PATCH] ARM: mx5: fix keypad clock Fabio Estevam
@ 2010-11-30 18:22 ` Uwe Kleine-König
0 siblings, 0 replies; 2+ messages in thread
From: Uwe Kleine-König @ 2010-11-30 18:22 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Tue, Nov 30, 2010 at 03:19:33PM -0200, Fabio Estevam wrote:
> This fixes the following error during keypad driver probe:
>
> imx-keypad imx-keypad: failed to get keypad clock
> imx-keypad: probe of imx-keypad failed with error -2
>
> Register keypad clock the same way as other imx platforms.
>
> Tested keypad succesfully on a MX51_3DS board.
s/succesfully/successfully/
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
> arch/arm/mach-mx5/clock-mx51-mx53.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/mach-mx5/clock-mx51-mx53.c b/arch/arm/mach-mx5/clock-mx51-mx53.c
> index 344ee8e..86fa0f4 100644
> --- a/arch/arm/mach-mx5/clock-mx51-mx53.c
> +++ b/arch/arm/mach-mx5/clock-mx51-mx53.c
> @@ -1091,7 +1091,7 @@ static struct clk_lookup mx51_lookups[] = {
> _REGISTER_CLOCK("mxc-ehci.1", "usb_ahb", ahb_clk)
> _REGISTER_CLOCK("fsl-usb2-udc", "usb", usboh3_clk)
> _REGISTER_CLOCK("fsl-usb2-udc", "usb_ahb", ahb_clk)
> - _REGISTER_CLOCK("imx-keypad.0", NULL, kpp_clk)
> + _REGISTER_CLOCK(NULL, "kpp", kpp_clk)
IMHO this is a step backwards. Better fix the driver to use the right
clock.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-11-30 18:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-11-30 17:19 [PATCH] ARM: mx5: fix keypad clock Fabio Estevam
2010-11-30 18:22 ` Uwe Kleine-König
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).