linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: tomi.valkeinen@nokia.com (Tomi Valkeinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/3] OMAP: Introduce Backlight driver for Sharp LS037V7DW01 LCD panel
Date: Wed, 01 Dec 2010 17:32:55 +0200	[thread overview]
Message-ID: <1291217575.10133.165.camel@tubuntu> (raw)
In-Reply-To: <1291118860-10325-1-git-send-email-bryan.wu@canonical.com>

Hi,

On Tue, 2010-11-30 at 20:07 +0800, ext Bryan Wu wrote:
> After instroducing generic DPI panel driver for OMAP DSS2 system, we need to
> split out backlight driver from Sharp LS037V7DW01 panel driver before we move
> to the generic DPI panel driver.
> 
> This patchset introcuded backlight driver and cleanup the old Sharp LS037V7DW01
> panel driver related code.
> 
> It's built on mainline 2.6.37-rc4
> 
> Bryan Wu (3):
>   Backlight: driver for Sharp LS037V7DW01 panel on OMAP machine
>   OMAP: move Sharp LS LCD panel device to generic DPI panel driver and new backlight driver
>   OMAP: DSS2: remove Sharp LS037V7DW01 panel driver

I don't think this is quite the right direction.

All the backlight driver does is call a function in the board file. It's
not really a "sharp ls backlight driver", but rather generic one. I'm
not even sure if it needs the dssdev pointer.

This kind of backlight is, in a sense, totally separate component from
the panel itself. All they have in common is that they are packaged in
the same physical display module, and they usually share the same
connector.

I have seen three kinds of backlights on OMAP devices:
- on/off GPIO (like on 3430 SDP)
- PWM based (zoom seems to have this)
- Panel controlled (Taal-panel. Also PWM based, but OMAP doesn't see
that)

The first two could (should?) be totally separate backlights from the
panel itself. For those, a generic backlight driver could perhaps work.
The third one needs to be quite tied to the panel driver, and I'm not
sure how easy it would be to have a separate driver for that.

 Tomi

  parent reply	other threads:[~2010-12-01 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-30 12:07 [PATCH 0/3] OMAP: Introduce Backlight driver for Sharp LS037V7DW01 LCD panel Bryan Wu
2010-11-30 12:07 ` [PATCH 1/3] Backlight: driver for Sharp LS037V7DW01 panel on OMAP machine Bryan Wu
2010-11-30 13:09   ` Janorkar, Mayuresh
2010-12-01 14:21     ` Bryan Wu
2010-11-30 12:07 ` [PATCH 2/3] OMAP: move Sharp LS LCD panel device to generic DPI panel driver and new backlight driver Bryan Wu
2010-11-30 12:07 ` [PATCH 3/3] OMAP: DSS2: remove Sharp LS037V7DW01 panel driver Bryan Wu
2010-12-01 15:32 ` Tomi Valkeinen [this message]
2010-12-06  5:06   ` [PATCH 0/3] OMAP: Introduce Backlight driver for Sharp LS037V7DW01 LCD panel Bryan Wu
2010-12-14 13:53     ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291217575.10133.165.camel@tubuntu \
    --to=tomi.valkeinen@nokia.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).