linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: maramaopercheseimorto@gmail.com (Alberto Panizzo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] support PMIC mc13892
Date: Mon, 06 Dec 2010 12:42:32 +0100	[thread overview]
Message-ID: <1291635752.3151.43.camel@realization> (raw)
In-Reply-To: <87tyirnpbm.fsf@lechat.rtp-net.org>

On lun, 2010-12-06 at 11:55 +0100, Arnaud Patard wrote:
> <yong.shen@freescale.com> writes:
> 
> Hi,
> 
> > From: Yong Shen <yong.shen@linaro.org>
> >
> > add support for mc13892, tested on mx51 babbage board
> 
> Will review/test it asap on my efikamx. thanks for working on this :)
> 
> >
> > Signed-off-by: Yong Shen <yong.shen@linaro.org>
> > ---
> >  drivers/mfd/Kconfig                   |    4 +
> >  drivers/regulator/Kconfig             |    8 +
> >  drivers/regulator/Makefile            |    1 +
> >  drivers/regulator/mc13892-regulator.c |  647 +++++++++++++++++++++++++++++++++
> >  include/linux/mfd/mc13892.h           |   38 ++
> >  5 files changed, 698 insertions(+), 0 deletions(-)
> >  create mode 100644 drivers/regulator/mc13892-regulator.c
> >  create mode 100644 include/linux/mfd/mc13892.h
> 
> [...]
> 
> > +
> > +static const int mc13892_vvideo[] = {
> > +	2500000, 2600000, 270000, 2775000,
> > +};
> 
> Should be :
> static const int mc13892_vvideo[] = {
>         270000, 2775000, 2500000, 2600000,
> };
> 
> I've spotted this in my code some time ago. VVIDEO voltages are not
> ascending order.

If this is true, also a private get_best_voltage_index have to be
developed for it.


-- 
Alberto!

        Be Persistent!
                - Greg Kroah-Hartman (FOSDEM 2010)

  reply	other threads:[~2010-12-06 11:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-06  6:25 [PATCH] support PMIC mc13892 yong.shen at freescale.com
2010-12-06  7:22 ` Uwe Kleine-König
2010-12-07  2:41   ` Yong Shen
2010-12-07  7:57   ` Yong Shen
2010-12-07  8:02     ` Uwe Kleine-König
2010-12-06 10:40 ` David Jander
2010-12-07  2:50   ` Yong Shen
2010-12-06 10:55 ` Arnaud Patard (Rtp)
2010-12-06 11:42   ` Alberto Panizzo [this message]
2010-12-06 11:55     ` Arnaud Patard (Rtp)
2010-12-06 13:12       ` Alberto Panizzo
2010-12-07  2:52   ` Yong Shen
2010-12-06 21:54 ` Marc Reilly
2010-12-07  7:14   ` [PATCH] Added i2c support for mc13xxx-core Marc Reilly
2010-12-07  8:32     ` Yong Shen
2010-12-07 10:09       ` Marc Reilly
2010-12-08  6:24     ` Yong Shen
2010-12-08  8:07       ` Marc Reilly
2010-12-08 10:42         ` Uwe Kleine-König
2010-12-07  7:23   ` Marc Reilly
2010-12-07  7:23   ` Marc Reilly

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291635752.3151.43.camel@realization \
    --to=maramaopercheseimorto@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).