Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: jamie@jamieiles.com (Jamie Iles)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: Fix warning with gcc 4.5.1 in alignment fixup
Date: Tue,  7 Dec 2010 20:28:44 +0000	[thread overview]
Message-ID: <1291753724-14437-1-git-send-email-jamie@jamieiles.com> (raw)

With GCC 4.5.1 we get the following warning:

	  CC      arch/arm/mm/alignment.o
	arch/arm/mm/alignment.c: In function 'do_alignment':
	arch/arm/mm/alignment.c:720:21: warning: 'offset.un' may be used
	uninitialized in this function

This warning is triggered for the LDM/STM instructions which don't have
a register offset so set the offset to 0 to keep GCC happy.

Cc: George G. Davis <gdavis@mvista.com>
Cc: Min Zhang <mzhang@mvista.com>
Signed-off-by: Jamie Iles <jamie@jamieiles.com>
---
 arch/arm/mm/alignment.c |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mm/alignment.c b/arch/arm/mm/alignment.c
index 724ba3b..298aaef 100644
--- a/arch/arm/mm/alignment.c
+++ b/arch/arm/mm/alignment.c
@@ -824,8 +824,10 @@ do_alignment(unsigned long addr, unsigned int fsr, struct pt_regs *regs)
 	case 0x08000000:	/* ldm or stm, or thumb-2 32bit instruction */
 		if (thumb2_32b)
 			handler = do_alignment_t32_to_handler(&instr, regs, &offset);
-		else
+		else {
 			handler = do_alignment_ldmstm;
+			offset.un = 0;
+		}
 		break;
 
 	default:
-- 
1.7.3.2

             reply	other threads:[~2010-12-07 20:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 20:28 Jamie Iles [this message]
2010-12-08  2:55 ` [PATCH] ARM: Fix warning with gcc 4.5.1 in alignment fixup George G. Davis
2011-01-06 15:33 ` Jamie Iles

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1291753724-14437-1-git-send-email-jamie@jamieiles.com \
    --to=jamie@jamieiles.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox