From: aaro.koskinen@nokia.com (Aaro Koskinen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/8] arm: omap: sdram-nokia: improve error handling
Date: Thu, 9 Dec 2010 18:39:21 +0200 [thread overview]
Message-ID: <1291912764-12823-6-git-send-email-aaro.koskinen@nokia.com> (raw)
In-Reply-To: <1291912764-12823-1-git-send-email-aaro.koskinen@nokia.com>
Actually check for errors: print an error log and return NULL.
Signed-off-by: Aaro Koskinen <aaro.koskinen@nokia.com>
---
arch/arm/mach-omap2/sdram-nokia.c | 8 ++++++--
1 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/sdram-nokia.c b/arch/arm/mach-omap2/sdram-nokia.c
index 1171451..863586b 100644
--- a/arch/arm/mach-omap2/sdram-nokia.c
+++ b/arch/arm/mach-omap2/sdram-nokia.c
@@ -223,10 +223,14 @@ struct omap_sdrc_params *nokia_get_sdram_timings(void)
int err = 0;
int i;
- for (i = 0; i < ARRAY_SIZE(nokia_timings); i++)
+ for (i = 0; i < ARRAY_SIZE(nokia_timings); i++) {
err |= sdrc_timings(i, nokia_timings[i].rate,
nokia_timings[i].data);
+ if (err)
+ pr_err("%s: error with rate %ld: %d\n", __func__,
+ nokia_timings[i].rate, err);
+ }
- return &nokia_sdrc_params[0];
+ return err ? NULL : nokia_sdrc_params;
}
--
1.5.6.5
next prev parent reply other threads:[~2010-12-09 16:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 16:39 [PATCH 0/8] arm: omap: add support for RM-680 Aaro Koskinen
2010-12-09 16:39 ` [PATCH 1/8] arm: omap: rename board-rx51-sdram.c to sdram-nokia.c Aaro Koskinen
2010-12-09 16:39 ` [PATCH 2/8] arm: omap: add sdram-nokia.h Aaro Koskinen
2010-12-09 16:45 ` Nishanth Menon
2010-12-09 16:39 ` [PATCH 3/8] arm: omap: sdram-nokia: prepare for new memory timings Aaro Koskinen
2010-12-09 16:39 ` [PATCH 4/8] arm: omap: sdram-nokia: use array to list timings Aaro Koskinen
2010-12-09 16:39 ` Aaro Koskinen [this message]
2010-12-09 16:39 ` [PATCH 6/8] arm: omap: sdram-nokia: delete redundant timing data Aaro Koskinen
2010-12-09 16:39 ` [PATCH 7/8] arm: omap: sdram-nokia: add 97.6/195.2 MHz " Aaro Koskinen
2010-12-09 16:39 ` [PATCH 8/8] arm: omap: add minimal support for RM-680 Aaro Koskinen
2010-12-09 17:03 ` Jamie Iles
2010-12-09 17:11 ` Aaro Koskinen
2010-12-09 17:29 ` Jamie Iles
2010-12-11 2:07 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291912764-12823-6-git-send-email-aaro.koskinen@nokia.com \
--to=aaro.koskinen@nokia.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).