From: plyatov@gmail.com (Igor Plyatov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] at91: Refactor Stamp9G20 and PControl G20 board file
Date: Fri, 10 Dec 2010 09:19:58 +0300 [thread overview]
Message-ID: <1291961998.3020.0.camel@homepc> (raw)
In-Reply-To: <1291889759-12281-1-git-send-email-christian.glindkamp@taskit.de>
Dear Christian,
> As PControl G20 is a carrier board for the Stamp9G20 SoM, some code can
> be shared. Therefore board-stamp9g20.c is refactored to allow reusing the
> SoM initialization and board-pcontrol-g20.c is modified to use it.
>
> Signed-off-by: Christian Glindkamp <christian.glindkamp@taskit.de>
> ---
>
> How about this approach? Compile tested for PControl G20 and run time tested
> for Stamp9G20 EVB and PortuxG20.
>
> Just a side note: PortuxG20 is not a carrier board for the Stamp9G20. It just
> shares so much with the evaluation board, that it makes sense to put them both
> into the same file. And there is no intention to put other boards into this
> file.
The idea from this patch is clean.
Yours patch does not apply to the kernel from
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git,
but I apply its content by hands and kernels compiled successfully with
stamp9g20_defconfig and pcontrol_g20_defconfig.
Please run ./scripts/checkpatch.pl with you patch and correct all errors
and warnings reported.
If you will correct this patch, to be applicable, then I will vote to
include it into mainline.
Which kernel repository and branch should I use for the AT91 ARM?
I just want to know - whereto send my next patch to support gms machine?
Best regards!
--
Igor Plyatov
next prev parent reply other threads:[~2010-12-10 6:19 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-07 14:42 [PATCH v2] mach-at91: Support for gms board added Igor Plyatov
2010-12-07 19:53 ` Ryan Mallon
2010-12-08 8:53 ` Nicolas Ferre
2010-12-08 14:03 ` Jean-Christophe PLAGNIOL-VILLARD
2010-12-08 19:29 ` Igor Plyatov
2010-12-08 14:50 ` Christian Glindkamp
2010-12-08 20:08 ` Ryan Mallon
2010-12-09 10:15 ` [PATCH] at91: Refactor Stamp9G20 and PControl G20 board file Christian Glindkamp
2010-12-10 3:38 ` Jean-Christophe PLAGNIOL-VILLARD
2010-12-10 9:03 ` Christian Glindkamp
2010-12-10 6:19 ` Igor Plyatov [this message]
[not found] ` <1291909193.6251.32.camel@homepc>
2010-12-10 8:44 ` Christian Glindkamp
2010-12-10 9:45 ` Nicolas Ferre
2010-12-08 19:26 ` [PATCH v2] mach-at91: Support for gms board added Igor Plyatov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291961998.3020.0.camel@homepc \
--to=plyatov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).