From: plyatov@gmail.com (Igor Plyatov)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ata: pata_at91.c bugfix for high master clock
Date: Sat, 11 Dec 2010 23:51:34 +0300 [thread overview]
Message-ID: <1292100694.27634.25.camel@homepc> (raw)
In-Reply-To: <20101211214044.37b866e0@realm>
Dear Sergey,
> > @@ -109,6 +111,11 @@ static void set_smc_timing(struct device *dev,
> > /* (CS0, CS1, DIR, OE) <= (CFCE1, CFCE2, CFRNW, NCSX)
> > timings */ ncs_read_setup = 1;
> > ncs_read_pulse = read_cycle - 2;
> > + if (ncs_read_pulse > NCS_RD_PULSE_LIMIT) {
> > + ncs_read_pulse = NCS_RD_PULSE_LIMIT;
> > + dev_dbg(dev, "ncs_read_pulse limited to maximal
> > value %lu\n",
>
> arguably 'dev_warn' would be better in this case
Done as "PATCH v2".
Best regards!
--
Igor Plyatov
next prev parent reply other threads:[~2010-12-11 20:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-11 3:37 [PATCH] ata: pata_at91.c bugfix for high master clock Igor Plyatov
2010-12-11 18:40 ` Sergey Matyukevich
2010-12-11 20:51 ` Igor Plyatov [this message]
[not found] <1292011430-20835-1-git-send-email-plyatov@gmail.com>
2010-12-11 19:16 ` Sergey Matyukevich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292100694.27634.25.camel@homepc \
--to=plyatov@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).