* [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification @ 2010-12-13 12:48 Nicolas Ferre 2010-12-14 8:44 ` Dan Williams 2010-12-14 12:05 ` Jean-Christophe PLAGNIOL-VILLARD 0 siblings, 2 replies; 3+ messages in thread From: Nicolas Ferre @ 2010-12-13 12:48 UTC (permalink / raw) To: linux-arm-kernel Buffer transfer size is the number of transfers to be performed in relation with the width of the _source_ interface. So in the DMA_FROM_DEVICE case, it should be the register width that should be taken into account. Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> --- drivers/dma/at_hdmac.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/dma/at_hdmac.c b/drivers/dma/at_hdmac.c index a0f3e6a..ea0ee81 100644 --- a/drivers/dma/at_hdmac.c +++ b/drivers/dma/at_hdmac.c @@ -722,7 +722,7 @@ atc_prep_slave_sg(struct dma_chan *chan, struct scatterlist *sgl, desc->lli.daddr = mem; desc->lli.ctrla = ctrla | ATC_DST_WIDTH(mem_width) - | len >> mem_width; + | len >> reg_width; desc->lli.ctrlb = ctrlb; if (!first) { -- 1.7.3 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification 2010-12-13 12:48 [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification Nicolas Ferre @ 2010-12-14 8:44 ` Dan Williams 2010-12-14 12:05 ` Jean-Christophe PLAGNIOL-VILLARD 1 sibling, 0 replies; 3+ messages in thread From: Dan Williams @ 2010-12-14 8:44 UTC (permalink / raw) To: linux-arm-kernel On Mon, Dec 13, 2010 at 4:48 AM, Nicolas Ferre <nicolas.ferre@atmel.com> wrote: > Buffer transfer size is the number of transfers to be performed in > relation with the width of the _source_ interface. > So in the DMA_FROM_DEVICE case, it should be the register width that > should be taken into account. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> > --- Applied. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification 2010-12-13 12:48 [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification Nicolas Ferre 2010-12-14 8:44 ` Dan Williams @ 2010-12-14 12:05 ` Jean-Christophe PLAGNIOL-VILLARD 1 sibling, 0 replies; 3+ messages in thread From: Jean-Christophe PLAGNIOL-VILLARD @ 2010-12-14 12:05 UTC (permalink / raw) To: linux-arm-kernel On 13:48 Mon 13 Dec , Nicolas Ferre wrote: > Buffer transfer size is the number of transfers to be performed in > relation with the width of the _source_ interface. > So in the DMA_FROM_DEVICE case, it should be the register width that > should be taken into account. > > Signed-off-by: Nicolas Ferre <nicolas.ferre@atmel.com> Acked-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com> Best Regards, J. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-12-14 12:05 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-12-13 12:48 [PATCH] dmaengine: at_hdmac: fix buffer transfer size specification Nicolas Ferre 2010-12-14 8:44 ` Dan Williams 2010-12-14 12:05 ` Jean-Christophe PLAGNIOL-VILLARD
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).