From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] msm: trout: add keypad support
Date: Mon, 13 Dec 2010 10:41:32 -0800 [thread overview]
Message-ID: <1292265692.2700.0.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <4D01D776.6000309@codeaurora.org>
On Fri, 2010-12-10 at 13:02 +0530, Trilok Soni wrote:
> Hi Daniel,
>
> On 12/10/2010 3:33 AM, Daniel Walker wrote:
> > On Thu, 2010-12-09 at 14:01 -0800, Arve Hj?nnev?g wrote:
> >> On Thu, Dec 9, 2010 at 9:45 AM, Daniel Walker <dwalker@codeaurora.org> wrote:
> >>> On Thu, 2010-12-09 at 12:36 +0530, Trilok Soni wrote:
> >>>
> >>>>> +static char *keycaps = "--qwerty";
> >>>>> +#undef MODULE_PARAM_PREFIX
> >>>>> +#define MODULE_PARAM_PREFIX "board_trout."
> >>>>> +module_param_named(keycaps, keycaps, charp, 0);
> >>>>
> >>>> I would like to know what is the use of this param?
> >>>
> >>> No idea .. It was part of Google's implementation ..
> >>>
> >>
> >> You removed the code that uses it. If you look at the original file
> >> you can see how it is used:
> >> http://android.git.kernel.org/?p=kernel/msm.git;a=blob;f=arch/arm/mach-msm/board-trout-keypad.c;hb=refs/heads/android-msm-2.6.35
> >> It is set by the bootloader according to the hardware version.
> >>
> >> You can also see that the "/* userspace needs to know about these
> >> changes as well */" comments refer to the code that changes the name
> >> of the input device.
> >>
> >> I don't think this change will work correctly with our existing
> >> user-space code though since you are now reporting the power-key,
> >> camera-key and slide-switch from a separate input device.
> >
> > Yeah, I did remove those parts.. I'm not sure where to put that stuff in
> > this new implementation. I can try to find an appropriate place , unless
> > you have some suggestions ?
>
> To support this, we need to override the input device .name and submit the patches
> for matrix keypad and gpio keys and let the name come through platform data.
>
> You can refer how I am doing in PM8058 keypad driver patch.
Not sure what your talking about .. I'm not making a new driver. I'm
just using the matrix keypad driver.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2010-12-13 18:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-09 0:24 [PATCH] msm: trout: add keypad support Daniel Walker
2010-12-09 6:34 ` Arce, Abraham
2010-12-09 7:02 ` Trilok Soni
2010-12-09 7:06 ` Trilok Soni
2010-12-09 17:45 ` Daniel Walker
2010-12-09 22:01 ` Arve Hjønnevåg
2010-12-09 22:03 ` Daniel Walker
2010-12-10 7:32 ` Trilok Soni
2010-12-10 17:10 ` Daniel Walker
2010-12-13 18:41 ` Daniel Walker [this message]
2010-12-14 6:49 ` Trilok Soni
2010-12-15 7:48 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292265692.2700.0.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).