From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] msm: gpiomux: Improve gpiomux interface design.
Date: Wed, 15 Dec 2010 06:26:33 -0800 [thread overview]
Message-ID: <1292423193.13887.1.camel@m0nster> (raw)
In-Reply-To: <1292259770-22972-1-git-send-email-gbean@codeaurora.org>
On Mon, 2010-12-13 at 09:02 -0800, Gregory Bean wrote:
> Fix the gpiomux interface by:
> - collapsing redundant abstractions into shared common ones
> - disconnecting gpiomux abstractions from particular MSM implementations
> - moving platform-specific details out of the common abstraction
> - moving implementation complexity out of the interface and back into
> the implementation, where it should have been in the first place
> - allowing for the future extension of the set of power states
> - disambiguating 'settings' and 'configurations'.
> - improving the initialization sequence to provide more flexibility
> - not forcing lines to reset to input mode at power transitions
Your doing too much in too large a patch. Could you break this up into
multiple patches?
Daniel
--
Sent by an consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
Forum.
prev parent reply other threads:[~2010-12-15 14:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-13 17:02 [PATCH 1/2] msm: gpiomux: Improve gpiomux interface design Gregory Bean
2010-12-13 17:02 ` [PATCH 2/2] msm: documentation: Update gpiomux documentation Gregory Bean
2010-12-15 14:26 ` Daniel Walker [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1292423193.13887.1.camel@m0nster \
--to=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).