* [PATCH] ARM: S3C64xx: Clear DMA_HALT upon start
@ 2011-01-03 1:53 Jassi Brar
2011-01-03 10:55 ` Kukjin Kim
0 siblings, 1 reply; 2+ messages in thread
From: Jassi Brar @ 2011-01-03 1:53 UTC (permalink / raw)
To: linux-arm-kernel
From: Jassi Brar <jassi.brar@samsung.com>
The stop function sets the DMA_HALT bit, which prevents
the DMA transfer to resume after stop, for example during
audio PAUSE/PLAY cycle. Clear the HALT bit during start.
Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
---
arch/arm/mach-s3c64xx/dma.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
index e7d03ab..d9aa072 100644
--- a/arch/arm/mach-s3c64xx/dma.c
+++ b/arch/arm/mach-s3c64xx/dma.c
@@ -212,6 +212,7 @@ static int s3c64xx_dma_start(struct s3c2410_dma_chan *chan)
config = readl(chan->regs + PL080S_CH_CONFIG);
config |= PL080_CONFIG_ENABLE;
+ config &= ~PL080_CONFIG_HALT;
pr_debug("%s: writing config %08x\n", __func__, config);
writel(config, chan->regs + PL080S_CH_CONFIG);
--
1.6.2.5
^ permalink raw reply related [flat|nested] 2+ messages in thread* [PATCH] ARM: S3C64xx: Clear DMA_HALT upon start
2011-01-03 1:53 [PATCH] ARM: S3C64xx: Clear DMA_HALT upon start Jassi Brar
@ 2011-01-03 10:55 ` Kukjin Kim
0 siblings, 0 replies; 2+ messages in thread
From: Kukjin Kim @ 2011-01-03 10:55 UTC (permalink / raw)
To: linux-arm-kernel
Jassi Brar wrote:
>
> From: Jassi Brar <jassi.brar@samsung.com>
>
> The stop function sets the DMA_HALT bit, which prevents
> the DMA transfer to resume after stop, for example during
> audio PAUSE/PLAY cycle. Clear the HALT bit during start.
>
> Signed-off-by: Jassi Brar <jassi.brar@samsung.com>
> ---
> arch/arm/mach-s3c64xx/dma.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-s3c64xx/dma.c b/arch/arm/mach-s3c64xx/dma.c
> index e7d03ab..d9aa072 100644
> --- a/arch/arm/mach-s3c64xx/dma.c
> +++ b/arch/arm/mach-s3c64xx/dma.c
> @@ -212,6 +212,7 @@ static int s3c64xx_dma_start(struct s3c2410_dma_chan
> *chan)
>
> config = readl(chan->regs + PL080S_CH_CONFIG);
> config |= PL080_CONFIG_ENABLE;
> + config &= ~PL080_CONFIG_HALT;
>
> pr_debug("%s: writing config %08x\n", __func__, config);
> writel(config, chan->regs + PL080S_CH_CONFIG);
> --
Ok...will apply.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-01-03 10:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-03 1:53 [PATCH] ARM: S3C64xx: Clear DMA_HALT upon start Jassi Brar
2011-01-03 10:55 ` Kukjin Kim
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).