From mboxrd@z Thu Jan  1 00:00:00 1970
From: khilman@ti.com (Kevin Hilman)
Date: Tue, 04 Jan 2011 14:45:54 -0800
Subject: [PATCH] OMAP: GPIO: fix _set_gpio_triggering() for OMAP2+
In-Reply-To: <87aajg7dzu.fsf@ti.com>
References: <1293620491-7201-1-git-send-email-ext-mika.1.westerberg@nokia.com>
	<87aajg7dzu.fsf@ti.com>
Message-ID: <1294181154.18162.39.camel@localhost>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On Tue, 2011-01-04 at 09:52 -0800, Kevin Hilman wrote:
> Mika Westerberg <ext-mika.1.westerberg@nokia.com> writes:
> 
> > In case on OMAP2+ we call set_24xx_gpio_triggering() instead of
> > updating reg and l values. However, at the end of the function we
> > perform a write:
> >
> > 	__raw_writel(l, reg);
> >
> > So on OMAP2+ we end up writing 0 to the bank->base which is not
> > correct (typically this points to GPIO_REVISION register).
> >
> > Fix this by returning immediately after call to
> > set_24xx_gpio_triggering().
> >
> > Signed-off-by: Mika Westerberg <ext-mika.1.westerberg@nokia.com>
> 
> Acked-by: Kevin Hilman <khilman@ti.com>
> 
> Tony, this should be added to omap-for-linus as it fixes a problem in
> the recently merged GPIO omap_device/hwmod conversion.

On second thought, it's a bit late for the main 2.6.38 window, so will
queue this in my pm-fixes branch for the .38-rc cycle.

Kevin