From: s.neumann@raumfeld.com (Sven Neumann)
To: linux-arm-kernel@lists.infradead.org
Subject: [patch] mtd: pxa3xx_nand: NULL dereference in pxa3xx_nand_probe
Date: Thu, 06 Jan 2011 14:45:01 +0100 [thread overview]
Message-ID: <1294321502.2218.5.camel@sven> (raw)
In-Reply-To: <20110106124525.GA1717@bicker>
Hi Dan,
On Thu, 2011-01-06 at 15:45 +0300, Dan Carpenter wrote:
> Could you test this patch? I don't have an arm so I can't compile this.
Yes, this change fixes the boot problem for me. Thanks for the quick
help.
> This was introduced in 18c81b1828f8 "mtd: pxa3xx_nand: remove the flash
> info in driver structure"
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Tested-by: Sven Neumann <s.neumann@raumfeld.com>
> diff --git a/drivers/mtd/nand/pxa3xx_nand.c b/drivers/mtd/nand/pxa3xx_nand.c
> index 17f8518..ea2c288 100644
> --- a/drivers/mtd/nand/pxa3xx_nand.c
> +++ b/drivers/mtd/nand/pxa3xx_nand.c
> @@ -885,6 +885,7 @@ static int pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)
> /* set info fields needed to __readid */
> info->read_id_bytes = (info->page_size == 2048) ? 4 : 2;
> info->reg_ndcr = ndcr;
> + info->cmdset = &default_cmdset;
>
> if (__readid(info, &id))
> return -ENODEV;
> @@ -915,7 +916,6 @@ static int pxa3xx_nand_detect_config(struct pxa3xx_nand_info *info)
>
> info->ndtr0cs0 = nand_readl(info, NDTR0CS0);
> info->ndtr1cs0 = nand_readl(info, NDTR1CS0);
> - info->cmdset = &default_cmdset;
>
> return 0;
> }
>
next prev parent reply other threads:[~2011-01-06 13:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 11:43 kernel NULL pointer dereference in pxa3xx_nand_probe Sven Neumann
2011-01-06 12:45 ` [patch] mtd: pxa3xx_nand: NULL " Dan Carpenter
2011-01-06 13:45 ` Sven Neumann [this message]
2011-01-06 14:05 ` [patch v2] " Dan Carpenter
2011-01-06 15:08 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1294321502.2218.5.camel@sven \
--to=s.neumann@raumfeld.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).