* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
@ 2011-01-11 23:45 Alexander Holler
2011-01-12 8:11 ` Uwe Kleine-König
2011-01-12 9:19 ` Russell King - ARM Linux
0 siblings, 2 replies; 6+ messages in thread
From: Alexander Holler @ 2011-01-11 23:45 UTC (permalink / raw)
To: linux-arm-kernel
When CONFIG_CMDLINE_FORCE is used, the warning
Ignoring unrecognised tag 0x54410009
was displayed. Change this to
Ignoring tag cmdline (using the default kernel command line)
Signed-off-by: Alexander Holler <holler@ahsoftware.de>
---
arch/arm/kernel/setup.c | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
index 336f14e..eed2425 100644
--- a/arch/arm/kernel/setup.c
+++ b/arch/arm/kernel/setup.c
@@ -649,15 +649,17 @@ static int __init parse_tag_revision(const struct tag *tag)
__tagtable(ATAG_REVISION, parse_tag_revision);
-#ifndef CONFIG_CMDLINE_FORCE
static int __init parse_tag_cmdline(const struct tag *tag)
{
+#ifndef CONFIG_CMDLINE_FORCE
strlcpy(default_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE);
+#else
+ pr_warning("Ignoring tag cmdline (using the default kernel command line)\n");
+#endif /* CONFIG_CMDLINE_FORCE */
return 0;
}
__tagtable(ATAG_CMDLINE, parse_tag_cmdline);
-#endif /* CONFIG_CMDLINE_FORCE */
/*
* Scan the tag table for this tag, and call its parse function.
--
1.7.3.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
2011-01-11 23:45 [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used Alexander Holler
@ 2011-01-12 8:11 ` Uwe Kleine-König
2011-01-12 9:17 ` Russell King - ARM Linux
2011-01-12 9:19 ` Russell King - ARM Linux
1 sibling, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-01-12 8:11 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
On Wed, Jan 12, 2011 at 12:45:56AM +0100, Alexander Holler wrote:
> When CONFIG_CMDLINE_FORCE is used, the warning
>
> Ignoring unrecognised tag 0x54410009
>
> was displayed. Change this to
>
> Ignoring tag cmdline (using the default kernel command line)
>
> Signed-off-by: Alexander Holler <holler@ahsoftware.de>
> ---
> arch/arm/kernel/setup.c | 6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> index 336f14e..eed2425 100644
> --- a/arch/arm/kernel/setup.c
> +++ b/arch/arm/kernel/setup.c
> @@ -649,15 +649,17 @@ static int __init parse_tag_revision(const struct tag *tag)
>
> __tagtable(ATAG_REVISION, parse_tag_revision);
>
> -#ifndef CONFIG_CMDLINE_FORCE
> static int __init parse_tag_cmdline(const struct tag *tag)
> {
> +#ifndef CONFIG_CMDLINE_FORCE
> strlcpy(default_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE);
> +#else
> + pr_warning("Ignoring tag cmdline (using the default kernel command line)\n");
> +#endif /* CONFIG_CMDLINE_FORCE */
Does it make sense at all to disable CONFIG_CMDLINE_FORCE? If not, I
suggest to remove it.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
2011-01-12 8:11 ` Uwe Kleine-König
@ 2011-01-12 9:17 ` Russell King - ARM Linux
2011-01-12 9:32 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-01-12 9:17 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 12, 2011 at 09:11:47AM +0100, Uwe Kleine-K?nig wrote:
> > diff --git a/arch/arm/kernel/setup.c b/arch/arm/kernel/setup.c
> > index 336f14e..eed2425 100644
> > --- a/arch/arm/kernel/setup.c
> > +++ b/arch/arm/kernel/setup.c
> > @@ -649,15 +649,17 @@ static int __init parse_tag_revision(const struct tag *tag)
> >
> > __tagtable(ATAG_REVISION, parse_tag_revision);
> >
> > -#ifndef CONFIG_CMDLINE_FORCE
> > static int __init parse_tag_cmdline(const struct tag *tag)
> > {
> > +#ifndef CONFIG_CMDLINE_FORCE
> > strlcpy(default_command_line, tag->u.cmdline.cmdline, COMMAND_LINE_SIZE);
> > +#else
> > + pr_warning("Ignoring tag cmdline (using the default kernel command line)\n");
> > +#endif /* CONFIG_CMDLINE_FORCE */
> Does it make sense at all to disable CONFIG_CMDLINE_FORCE? If not, I
> suggest to remove it.
Eeh? Do you understand what CONFIG_CMDLINE_FORCE is and what effect it
has?
When CONFIG_CMDLINE_FORCE is enabled, we ignore the command line passed
in from the boot loader and always use the built-in command line. When
CONFIG_CMDLINE_FORCE is disabled, we will use the boot loader supplied
command line if present.
"Does it make sense at all to disable CONFIG_CMDLINE_FORCE" so, if you
always have it enabled, you can never pass in a command line from a boot
loader. That's an absolutely idiotic idea.
_Most_ of us want to pass in command lines from the boot loader so we can
configure things.
Please, if you don't understand, ask questions rather than making
completely misleading review comments which may confuse patch submitters.
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
2011-01-12 9:17 ` Russell King - ARM Linux
@ 2011-01-12 9:32 ` Uwe Kleine-König
2011-01-12 12:42 ` Alexander Holler
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2011-01-12 9:32 UTC (permalink / raw)
To: linux-arm-kernel
Hello Russell,
On Wed, Jan 12, 2011 at 09:17:16AM +0000, Russell King - ARM Linux wrote:
> > Does it make sense at all to disable CONFIG_CMDLINE_FORCE? If not, I
> > suggest to remove it.
>
> Eeh? Do you understand what CONFIG_CMDLINE_FORCE is and what effect it
> has?
>
> When CONFIG_CMDLINE_FORCE is enabled, we ignore the command line passed
> in from the boot loader and always use the built-in command line. When
> CONFIG_CMDLINE_FORCE is disabled, we will use the boot loader supplied
> command line if present.
>
> "Does it make sense at all to disable CONFIG_CMDLINE_FORCE" so, if you
> always have it enabled, you can never pass in a command line from a boot
> loader. That's an absolutely idiotic idea.
>
> _Most_ of us want to pass in command lines from the boot loader so we can
> configure things.
ah, I thought the effect of CONFIG_CMDLINE_FORCE would be its inverse.
And ok, this is probably about broken boot loaders that I'm just not
used to.
> Please, if you don't understand, ask questions rather than making
> completely misleading review comments which may confuse patch submitters.
IMHO "Does it make sense at all to disable CONFIG_CMDLINE_FORCE?" is a
question, isn't it?
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-K?nig |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
2011-01-12 9:32 ` Uwe Kleine-König
@ 2011-01-12 12:42 ` Alexander Holler
0 siblings, 0 replies; 6+ messages in thread
From: Alexander Holler @ 2011-01-12 12:42 UTC (permalink / raw)
To: linux-arm-kernel
Hello,
Am 12.01.2011 10:32, schrieb Uwe Kleine-K?nig:
> Hello Russell,ah, I thought the effect of CONFIG_CMDLINE_FORCE would be its inverse.
> And ok, this is probably about broken boot loaders that I'm just not
> used to.
>
The real intention of CONFIG_CMD_FORCE was hotplug. Take a device with a
bootloader wich loads the kernel from the first partition of a
changeable media (e.g. usb-hd).
Without that option you would have to use the same command line for all
medias.
But I find it also very handy for rescue-kernels and such.
Regards,
Alexander
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used
2011-01-11 23:45 [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used Alexander Holler
2011-01-12 8:11 ` Uwe Kleine-König
@ 2011-01-12 9:19 ` Russell King - ARM Linux
1 sibling, 0 replies; 6+ messages in thread
From: Russell King - ARM Linux @ 2011-01-12 9:19 UTC (permalink / raw)
To: linux-arm-kernel
On Wed, Jan 12, 2011 at 12:45:56AM +0100, Alexander Holler wrote:
> When CONFIG_CMDLINE_FORCE is used, the warning
>
> Ignoring unrecognised tag 0x54410009
>
> was displayed. Change this to
>
> Ignoring tag cmdline (using the default kernel command line)
Patch is fine, can you send it to the patch system please?
Thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-01-12 12:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-11 23:45 [PATCH v2] ARM: Change misleading warning when CONFIG_CMDLINE_FORCE is used Alexander Holler
2011-01-12 8:11 ` Uwe Kleine-König
2011-01-12 9:17 ` Russell King - ARM Linux
2011-01-12 9:32 ` Uwe Kleine-König
2011-01-12 12:42 ` Alexander Holler
2011-01-12 9:19 ` Russell King - ARM Linux
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).