* [PATCHv3 0/2] omap3: Devkit8000: misc fixes @ 2011-01-18 6:58 Thomas Weber 2011-01-18 6:58 ` [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin Thomas Weber 2011-01-18 6:58 ` [PATCHv3 2/2] OMAP3: Devkit8000: Fix tps65930 pullup/pulldown configuration Thomas Weber 0 siblings, 2 replies; 4+ messages in thread From: Thomas Weber @ 2011-01-18 6:58 UTC (permalink / raw) To: linux-arm-kernel Here is a set of misc fixes for the devkit8000. The only really notable one is the lcd enable gpio fix. It gets rid of some nasty low level twl4030 calls and replaces them with generic gpio calls. It also fixes a bug where the screen would not turn off when blanking. Changes from v1: Pull the indention fix into "Change lcd power pin". Change the pin for lcd pwren. Fix the pullup/pulldown configuration after lcd prwen correction. Changes from v2: Better comment for removing low level functions used for twl4030 gpio Fix indention => indentation in comment Daniel Morsing (1): OMAP3: Devkit8000: Fix tps65930 pullup/pulldown configuration Thomas Weber (1): OMAP3: Devkit8000: Change lcd power pin arch/arm/mach-omap2/board-devkit8000.c | 10 +++------- 1 files changed, 3 insertions(+), 7 deletions(-) -- 1.7.4.rc2 ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin 2011-01-18 6:58 [PATCHv3 0/2] omap3: Devkit8000: misc fixes Thomas Weber @ 2011-01-18 6:58 ` Thomas Weber 2011-01-18 9:02 ` Varadarajan, Charulatha 2011-01-18 6:58 ` [PATCHv3 2/2] OMAP3: Devkit8000: Fix tps65930 pullup/pulldown configuration Thomas Weber 1 sibling, 1 reply; 4+ messages in thread From: Thomas Weber @ 2011-01-18 6:58 UTC (permalink / raw) To: linux-arm-kernel This patch fixes a wrongly used lcd enable pin. The Devkit8000 uses twl4030_ledA configured as output gpio only for the lcd enable line. twl4030_gpio.1 is used through the generic gpio functions while ledA is used via low level twl4030 calls. Remove the low level calls and use the generic gpio functions for initialization and use of ledA. This also fixes a bug where the lcd would not power down when blanking. Fix indentation issue. The comment line uses 8 whitespace. This is replaced with one tabulator. Reported-by: Daniel Morsing <daniel.morsing@gmail.com> Signed-off-by: Thomas Weber <weber@corscience.de> --- arch/arm/mach-omap2/board-devkit8000.c | 7 ++----- 1 files changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c index 451e7ff..719f4e5 100644 --- a/arch/arm/mach-omap2/board-devkit8000.c +++ b/arch/arm/mach-omap2/board-devkit8000.c @@ -114,9 +114,6 @@ static struct omap2_hsmmc_info mmc[] = { static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev) { - twl_i2c_write_u8(TWL4030_MODULE_GPIO, 0x80, REG_GPIODATADIR1); - twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0); - if (gpio_is_valid(dssdev->reset_gpio)) gpio_set_value_cansleep(dssdev->reset_gpio, 1); return 0; @@ -245,8 +242,8 @@ static int devkit8000_twl_gpio_setup(struct device *dev, /* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */ gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1; - /* gpio + 1 is "LCD_PWREN" (out, active high) */ - devkit8000_lcd_device.reset_gpio = gpio + 1; + /* TWL4030_GPIO_MAX + 0 is "LCD_PWREN" (out, active high) */ + devkit8000_lcd_device.reset_gpio = gpio + TWL4030_GPIO_MAX + 0; gpio_request(devkit8000_lcd_device.reset_gpio, "LCD_PWREN"); /* Disable until needed */ gpio_direction_output(devkit8000_lcd_device.reset_gpio, 0); -- 1.7.4.rc2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin 2011-01-18 6:58 ` [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin Thomas Weber @ 2011-01-18 9:02 ` Varadarajan, Charulatha 0 siblings, 0 replies; 4+ messages in thread From: Varadarajan, Charulatha @ 2011-01-18 9:02 UTC (permalink / raw) To: linux-arm-kernel On Tue, Jan 18, 2011 at 12:28, Thomas Weber <weber@corscience.de> wrote: > This patch fixes a wrongly used lcd enable pin. > > The Devkit8000 uses twl4030_ledA configured as output gpio only for the > lcd enable line. twl4030_gpio.1 is used through the generic gpio functions > while ledA is used via low level twl4030 calls. > > Remove the low level calls and use the generic gpio functions for > initialization and use of ledA. > > This also fixes a bug where the lcd would not power down when blanking. > > Fix indentation issue. The comment line uses 8 whitespace. > This is replaced with one tabulator. > > Reported-by: Daniel Morsing <daniel.morsing@gmail.com> > Signed-off-by: Thomas Weber <weber@corscience.de> > --- > ?arch/arm/mach-omap2/board-devkit8000.c | ? ?7 ++----- > ?1 files changed, 2 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c > index 451e7ff..719f4e5 100644 > --- a/arch/arm/mach-omap2/board-devkit8000.c > +++ b/arch/arm/mach-omap2/board-devkit8000.c > @@ -114,9 +114,6 @@ static struct omap2_hsmmc_info mmc[] = { > > ?static int devkit8000_panel_enable_lcd(struct omap_dss_device *dssdev) > ?{ > - ? ? ? twl_i2c_write_u8(TWL4030_MODULE_GPIO, 0x80, REG_GPIODATADIR1); > - ? ? ? twl_i2c_write_u8(TWL4030_MODULE_LED, 0x0, 0x0); > - > ? ? ? ?if (gpio_is_valid(dssdev->reset_gpio)) > ? ? ? ? ? ? ? ?gpio_set_value_cansleep(dssdev->reset_gpio, 1); > ? ? ? ?return 0; > @@ -245,8 +242,8 @@ static int devkit8000_twl_gpio_setup(struct device *dev, > ? ? ? ?/* TWL4030_GPIO_MAX + 1 == ledB, PMU_STAT (out, active low LED) */ > ? ? ? ?gpio_leds[2].gpio = gpio + TWL4030_GPIO_MAX + 1; > > - ? ? ? ?/* gpio + 1 is "LCD_PWREN" (out, active high) */ > - ? ? ? devkit8000_lcd_device.reset_gpio = gpio + 1; > + ? ? ? /* TWL4030_GPIO_MAX + 0 is "LCD_PWREN" (out, active high) */ > + ? ? ? devkit8000_lcd_device.reset_gpio = gpio + TWL4030_GPIO_MAX + 0; > ? ? ? ?gpio_request(devkit8000_lcd_device.reset_gpio, "LCD_PWREN"); Consider checking the return value of gpio_request(). > ? ? ? ?/* Disable until needed */ > ? ? ? ?gpio_direction_output(devkit8000_lcd_device.reset_gpio, 0); > -- > 1.7.4.rc2 > ^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCHv3 2/2] OMAP3: Devkit8000: Fix tps65930 pullup/pulldown configuration 2011-01-18 6:58 [PATCHv3 0/2] omap3: Devkit8000: misc fixes Thomas Weber 2011-01-18 6:58 ` [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin Thomas Weber @ 2011-01-18 6:58 ` Thomas Weber 1 sibling, 0 replies; 4+ messages in thread From: Thomas Weber @ 2011-01-18 6:58 UTC (permalink / raw) To: linux-arm-kernel From: Daniel Morsing <daniel.morsing@gmail.com> gpio7 on the tps65930 is used as an output on the devkit8000 and gpio1 is not connected. Remove gpio7 and change gpio1 to pulldown Signed-off-by: Daniel Morsing <daniel.morsing@gmail.com> --- arch/arm/mach-omap2/board-devkit8000.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-omap2/board-devkit8000.c b/arch/arm/mach-omap2/board-devkit8000.c index 719f4e5..9fb416b 100644 --- a/arch/arm/mach-omap2/board-devkit8000.c +++ b/arch/arm/mach-omap2/board-devkit8000.c @@ -262,8 +262,7 @@ static struct twl4030_gpio_platform_data devkit8000_gpio_data = { .irq_base = TWL4030_GPIO_IRQ_BASE, .irq_end = TWL4030_GPIO_IRQ_END, .use_leds = true, - .pullups = BIT(1), - .pulldowns = BIT(2) | BIT(6) | BIT(7) | BIT(8) | BIT(13) + .pulldowns = BIT(1) | BIT(2) | BIT(6) | BIT(8) | BIT(13) | BIT(15) | BIT(16) | BIT(17), .setup = devkit8000_twl_gpio_setup, }; -- 1.7.4.rc2 ^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-18 9:02 UTC | newest] Thread overview: 4+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2011-01-18 6:58 [PATCHv3 0/2] omap3: Devkit8000: misc fixes Thomas Weber 2011-01-18 6:58 ` [PATCHv3 1/2] OMAP3: Devkit8000: Change lcd power pin Thomas Weber 2011-01-18 9:02 ` Varadarajan, Charulatha 2011-01-18 6:58 ` [PATCHv3 2/2] OMAP3: Devkit8000: Fix tps65930 pullup/pulldown configuration Thomas Weber
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).