From: dwalker@codeaurora.org (Daniel Walker)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/4] msm: clock: Remove unused code and definitions
Date: Tue, 25 Jan 2011 14:02:17 -0800 [thread overview]
Message-ID: <1295992937.25496.75.camel@c-dwalke-linux.qualcomm.com> (raw)
In-Reply-To: <4D3F4609.3000808@codeaurora.org>
On Tue, 2011-01-25 at 13:52 -0800, Saravana Kannan wrote:
> On 01/25/2011 01:38 PM, Daniel Walker wrote:
> > On Mon, 2011-01-24 at 19:45 -0800, Stephen Boyd wrote:
> >> Remove dead code and push out clock-7x30.h and clock-pcom.h to
> >> where they are actually used.
> >>
> >
> > I'd do two patches for this. The stuff your doing is too disconnected.
> >
> > Daniel
> >
> There is a whole bunch of unused code in the clock files and it's being
> deleted. I don't see a point of splitting it up per file.
It's easier to review when changes aren't merged that don't related to
each other.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
next prev parent reply other threads:[~2011-01-25 22:02 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 3:45 [PATCH 0/4] MSM: clock debugfs and cleanups Stephen Boyd
2011-01-25 3:45 ` [PATCH 1/4] msm: clock: Remove unused code and definitions Stephen Boyd
2011-01-25 21:38 ` Daniel Walker
2011-01-25 21:52 ` Saravana Kannan
2011-01-25 22:02 ` Daniel Walker [this message]
2011-01-26 22:01 ` David Brown
2011-01-26 22:03 ` Daniel Walker
2011-01-26 22:50 ` Stephen Boyd
2011-01-25 3:45 ` [PATCH 2/4] msm: clock: Move debugfs code from clock.c to clock-debug.c Stephen Boyd
2011-01-25 3:45 ` [PATCH 3/4] msm: clock: Invert debugfs directory layout Stephen Boyd
2011-01-25 3:45 ` [PATCH 4/4] msm: clock: Add support for more proc_comm clocks Stephen Boyd
2011-01-25 21:58 ` Daniel Walker
2011-01-26 22:03 ` David Brown
2011-01-26 22:04 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1295992937.25496.75.camel@c-dwalke-linux.qualcomm.com \
--to=dwalker@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).