linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dave.martin@linaro.org (Dave Martin)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] ARM: Define wfi() macro for v6 processors
Date: Tue,  8 Feb 2011 11:01:25 +0000	[thread overview]
Message-ID: <1297162885-2975-1-git-send-email-dave.martin@linaro.org> (raw)

For v6, wfi is architected as a defined MCR instruction, so
use that definition.

Doing a no-op instead of wfi() is probably bad, so for older
processors than v6, wfi() is not defined.  If needed, some CPU-
specific wfi() will have to be defined elsewhere.

Signed-off-by: Dave Martin <dave.martin@linaro.org>
---
--------------------------------------------------------------------
v2 notes:

The first version of this patch incorrectly specified the write
buffer drain MCR (c7, c5, 4) instead of WFI (c7, c0, 5).  Now fixed.
I hang my head in shame!

The first version of this patch attempted to define wfe() and sev()
to empty asms also for pre-v6K processors.  Having thought about
this some more, I think that it may be better to wait until this
is actually needed before attempting to define these to anything.
Having no definition (giving a build error) seems safer than
having a wrong definition.

 arch/arm/include/asm/system.h |    3 +++
 1 files changed, 3 insertions(+), 0 deletions(-)

diff --git a/arch/arm/include/asm/system.h b/arch/arm/include/asm/system.h
index 97f6d60..f39cf09 100644
--- a/arch/arm/include/asm/system.h
+++ b/arch/arm/include/asm/system.h
@@ -129,6 +129,9 @@ extern unsigned int user_debug;
 #define sev()	__asm__ __volatile__ ("sev" : : : "memory")
 #define wfe()	__asm__ __volatile__ ("wfe" : : : "memory")
 #define wfi()	__asm__ __volatile__ ("wfi" : : : "memory")
+#elif __LINUX_ARM_ARCH__ == 6
+#define wfi() __asm__ __volatile__ ("mcr p15, 0, %0, c7, c0, 4" \
+				    : : "r" (0) : "memory")
 #endif
 
 #if __LINUX_ARM_ARCH__ >= 7
-- 
1.7.1

             reply	other threads:[~2011-02-08 11:01 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-08 11:01 Dave Martin [this message]
2011-02-08 11:08 ` [PATCH v2] ARM: Define wfi() macro for v6 processors Russell King - ARM Linux
2011-02-08 11:16   ` Dave Martin
2011-02-08 12:11   ` Arnd Bergmann
2011-02-08 12:13     ` Russell King - ARM Linux
2011-02-08 12:53       ` Arnd Bergmann
2011-02-08 14:45         ` Dave Martin
2011-02-08 14:54           ` Santosh Shilimkar
2011-02-08 15:09             ` Dave Martin
2011-02-08 15:17               ` Arnd Bergmann
2011-02-08 16:32                 ` Russell King - ARM Linux
2011-02-08 16:58                   ` Arnd Bergmann
2011-02-08 17:15                     ` Dave Martin
2011-02-08 15:15           ` Arnd Bergmann
2011-02-08 15:30             ` Dave Martin
2011-02-08 15:42               ` Arnd Bergmann
2011-02-08 16:21                 ` Dave Martin
2011-02-09 10:07                   ` Arnd Bergmann
2011-02-08 16:25             ` Russell King - ARM Linux
2011-02-08 16:31               ` Dave Martin
2011-02-08 16:47               ` Arnd Bergmann
2011-02-08 16:55                 ` Russell King - ARM Linux
2011-02-08 17:00                   ` Dave Martin
2011-02-08 16:20           ` Russell King - ARM Linux
2011-02-08 16:28             ` Dave Martin
2011-02-08 12:22     ` Dave Martin
2011-02-08 12:31       ` Santosh Shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1297162885-2975-1-git-send-email-dave.martin@linaro.org \
    --to=dave.martin@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).