* [PATCH] omap iommu: print module name on error messages
@ 2011-02-12 10:02 David Cohen
2011-02-14 13:41 ` Hiroshi DOYU
0 siblings, 1 reply; 3+ messages in thread
From: David Cohen @ 2011-02-12 10:02 UTC (permalink / raw)
To: linux-arm-kernel
OMAP IOMMU generic layer doesn't need ot print function name during
error messages. Print module name instead which is more useful.
Signed-off-by: David Cohen <dacohen@gmail.com>
---
arch/arm/plat-omap/iommu.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/plat-omap/iommu.c b/arch/arm/plat-omap/iommu.c
index b1107c0..f55f458 100644
--- a/arch/arm/plat-omap/iommu.c
+++ b/arch/arm/plat-omap/iommu.c
@@ -806,7 +806,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
iopgd = iopgd_offset(obj, da);
if (!iopgd_is_table(*iopgd)) {
- dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", __func__,
+ dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x\n", obj->name,
da, iopgd, *iopgd);
return IRQ_NONE;
}
@@ -814,7 +814,7 @@ static irqreturn_t iommu_fault_handler(int irq, void *data)
iopte = iopte_offset(iopgd, da);
dev_err(obj->dev, "%s: da:%08x pgd:%p *pgd:%08x pte:%p *pte:%08x\n",
- __func__, da, iopgd, *iopgd, iopte, *iopte);
+ obj->name, da, iopgd, *iopgd, iopte, *iopte);
return IRQ_NONE;
}
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] omap iommu: print module name on error messages
2011-02-12 10:02 [PATCH] omap iommu: print module name on error messages David Cohen
@ 2011-02-14 13:41 ` Hiroshi DOYU
2011-02-17 23:57 ` Tony Lindgren
0 siblings, 1 reply; 3+ messages in thread
From: Hiroshi DOYU @ 2011-02-14 13:41 UTC (permalink / raw)
To: linux-arm-kernel
From: ext David Cohen <dacohen@gmail.com>
Subject: [PATCH] omap iommu: print module name on error messages
Date: Sat, 12 Feb 2011 12:02:29 +0200
> OMAP IOMMU generic layer doesn't need ot print function name during
> error messages. Print module name instead which is more useful.
Agree. This makes more sense.
> Signed-off-by: David Cohen <dacohen@gmail.com>
> ---
> arch/arm/plat-omap/iommu.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] omap iommu: print module name on error messages
2011-02-14 13:41 ` Hiroshi DOYU
@ 2011-02-17 23:57 ` Tony Lindgren
0 siblings, 0 replies; 3+ messages in thread
From: Tony Lindgren @ 2011-02-17 23:57 UTC (permalink / raw)
To: linux-arm-kernel
* Hiroshi DOYU <Hiroshi.DOYU@nokia.com> [110214 05:39]:
> From: ext David Cohen <dacohen@gmail.com>
> Subject: [PATCH] omap iommu: print module name on error messages
> Date: Sat, 12 Feb 2011 12:02:29 +0200
>
> > OMAP IOMMU generic layer doesn't need ot print function name during
> > error messages. Print module name instead which is more useful.
>
> Agree. This makes more sense.
Applying to devel-iommu-mailbox for the upcoming merge window.
Tony
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-02-17 23:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-12 10:02 [PATCH] omap iommu: print module name on error messages David Cohen
2011-02-14 13:41 ` Hiroshi DOYU
2011-02-17 23:57 ` Tony Lindgren
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).