From: dacohen@gmail.com (David Cohen)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/2] OMAP2+: IOMMU: don't print fault warning on specific layer
Date: Wed, 16 Feb 2011 21:35:50 +0200 [thread overview]
Message-ID: <1297884951-3019-2-git-send-email-dacohen@gmail.com> (raw)
In-Reply-To: <1297884951-3019-1-git-send-email-dacohen@gmail.com>
IOMMU upper layer and user are responsible to handle a fault and to
define whether it will end up as an error or not. OMAP2+ specific
layer should not print anything in such case.
Signed-off-by: David Cohen <dacohen@gmail.com>
---
arch/arm/mach-omap2/iommu2.c | 16 ----------------
1 files changed, 0 insertions(+), 16 deletions(-)
diff --git a/arch/arm/mach-omap2/iommu2.c b/arch/arm/mach-omap2/iommu2.c
index 14ee686..49a1e5e 100644
--- a/arch/arm/mach-omap2/iommu2.c
+++ b/arch/arm/mach-omap2/iommu2.c
@@ -145,15 +145,7 @@ static void omap2_iommu_set_twl(struct iommu *obj, bool on)
static u32 omap2_iommu_fault_isr(struct iommu *obj, u32 *ra)
{
- int i;
u32 stat, da;
- const char *err_msg[] = {
- "tlb miss",
- "translation fault",
- "emulation miss",
- "table walk fault",
- "multi hit fault",
- };
stat = iommu_read_reg(obj, MMU_IRQSTATUS);
stat &= MMU_IRQ_MASK;
@@ -163,14 +155,6 @@ static u32 omap2_iommu_fault_isr(struct iommu *obj, u32 *ra)
da = iommu_read_reg(obj, MMU_FAULT_AD);
*ra = da;
- dev_err(obj->dev, "%s:\tda:%08x ", __func__, da);
-
- for (i = 0; i < ARRAY_SIZE(err_msg); i++) {
- if (stat & (1 << i))
- printk("%s ", err_msg[i]);
- }
- printk("\n");
-
iommu_write_reg(obj, stat, MMU_IRQSTATUS);
return stat;
--
1.7.2.3
next prev parent reply other threads:[~2011-02-16 19:35 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-16 19:35 [PATCH v3 0/2] OMAP: IOMMU fault callback support David Cohen
2011-02-16 19:35 ` David Cohen [this message]
2011-02-16 19:35 ` [PATCH v3 2/2] OMAP: IOMMU: add support to callback during fault handling David Cohen
2011-02-21 8:18 ` Hiroshi DOYU
2011-02-21 8:22 ` Felipe Balbi
2011-02-21 8:57 ` David Cohen
2011-02-21 9:20 ` Felipe Balbi
2011-02-21 9:07 ` David Cohen
2011-02-21 9:51 ` Hiroshi DOYU
2011-02-21 18:43 ` Ramirez Luna, Omar
2011-02-21 21:12 ` David Cohen
2011-02-21 23:25 ` Ramirez Luna, Omar
2011-02-21 23:48 ` David Cohen
2011-02-23 1:17 ` Guzman Lugo, Fernando
2011-02-23 9:45 ` David Cohen
2011-02-23 13:39 ` Guzman Lugo, Fernando
2011-02-23 19:54 ` David Cohen
2011-02-23 20:56 ` Sakari Ailus
2011-02-23 21:48 ` Guzman Lugo, Fernando
2011-02-24 6:39 ` David Cohen
2011-02-23 21:12 ` Guzman Lugo, Fernando
2011-02-23 20:09 ` Sakari Ailus
2011-02-23 20:21 ` David Cohen
2011-02-23 21:30 ` Guzman Lugo, Fernando
2011-02-24 8:35 ` Felipe Balbi
2011-02-24 11:26 ` David Cohen
2011-02-24 11:29 ` Felipe Balbi
2011-02-24 17:58 ` Guzman Lugo, Fernando
2011-02-24 20:31 ` Tony Lindgren
2011-02-24 22:21 ` Tony Lindgren
2011-02-21 9:52 ` [PATCH v3 0/2] OMAP: IOMMU fault callback support Hiroshi DOYU
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297884951-3019-2-git-send-email-dacohen@gmail.com \
--to=dacohen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).