From: jhnikula@gmail.com (Jarkko Nikula)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c
Date: Sun, 20 Feb 2011 22:04:08 +0200 [thread overview]
Message-ID: <1298232248-347-1-git-send-email-jhnikula@gmail.com> (raw)
In-Reply-To: <1298193466-29534-1-git-send-email-jhnikula@gmail.com>
There is a linker error from lcd_2430sdp.c if CONFIG_TWL4030_CORE is not
set. This can be triggered on OMAP2 builds where OMAP3 or OMAP4 are not set.
drivers/built-in.o: In function `sdp2430_panel_disable':
drivers/video/omap/lcd_2430sdp.c:123: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:124: undefined reference to `twl_i2c_write_u8'
drivers/built-in.o: In function `sdp2430_panel_enable':
drivers/video/omap/lcd_2430sdp.c:110: undefined reference to `twl_i2c_write_u8'
drivers/video/omap/lcd_2430sdp.c:112: undefined reference to `twl_i2c_write_u8'
Fix this by adding TWL4030_CORE dependency to CONFIG_MACH_OMAP_2430SDP as
there is no own entry in drivers/video/omap/Kconfig.
Signed-off-by: Jarkko Nikula <jhnikula@gmail.com>
Cc: Tomi Valkeinen <tomi.valkeinen@ti.com>
---
Resend = forgot to cc LAKML.
Quite old issue most probably. Can be triggered in mainline anyway.
---
arch/arm/mach-omap2/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/Kconfig b/arch/arm/mach-omap2/Kconfig
index b9d8a7b..bfdf240 100644
--- a/arch/arm/mach-omap2/Kconfig
+++ b/arch/arm/mach-omap2/Kconfig
@@ -132,6 +132,7 @@ config MACH_OMAP_2430SDP
depends on SOC_OMAP2430
default y
select OMAP_PACKAGE_ZAC
+ select TWL4030_CORE
config MACH_OMAP3_BEAGLE
bool "OMAP3 BEAGLE board"
--
1.7.0.4
next parent reply other threads:[~2011-02-20 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1298193466-29534-1-git-send-email-jhnikula@gmail.com>
2011-02-20 20:04 ` Jarkko Nikula [this message]
2011-02-24 21:26 ` [PATCH resend] omap: Fix linker error in drivers/video/omap/lcd_2430sdp.c Tony Lindgren
2011-02-28 14:47 ` Jarkko Nikula
2011-02-28 15:09 ` Tomi Valkeinen
2011-03-01 1:39 ` Tony Lindgren
2011-03-01 6:29 ` Tomi Valkeinen
2011-03-02 17:36 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298232248-347-1-git-send-email-jhnikula@gmail.com \
--to=jhnikula@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).