linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: dedekind1@gmail.com (Artem Bityutskiy)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V4 0/6] pxa3xx_nand update series set version 4
Date: Fri, 25 Feb 2011 12:39:31 +0200	[thread overview]
Message-ID: <1298630371.2798.43.camel@localhost> (raw)
In-Reply-To: <1298019428-7809-1-git-send-email-leiwen@marvell.com>

On Fri, 2011-02-18 at 16:57 +0800, Lei Wen wrote:
> Change from previous version:
> rework the patch set accroding to Eric's suggestion.
> Move the recode judgement to the after command execution.
> 
> Lei Wen (6):
>   pxa3xx_nand: make scan procedure more clear
>   pxa3xx_nand: rework irq logic
>   pxa3xx_nand: discard wait_for_event,write_cmd,__readid function
>   pxa3xx_nand: unify prepare command
>   pxa3xx_nand: mtd scan id process could be defined by driver itself
>   pxa3xx_nand: clean the keep configure code

Hi, could you please make checkpatch.pl happy and re-send the patches?

There are many issues. OK, some are fine, do not try to fix them, e.g.:

WARNING: line over 80 characters
#127: FILE: drivers/mtd/nand/pxa3xx_nand.c:221:
+{ "512MiB 16-bit", 0xcc2c,  64, 2048, 16, 16, 4096, &default_cmdset, &timing[2] },

but some are clearly stylistic errors:

ERROR: else should follow close brace '}'
#249: FILE: drivers/mtd/nand/pxa3xx_nand.c:539:
+                }
+                else {

etc.

Thanks!

-- 
Best Regards,
Artem Bityutskiy (????? ????????)

  parent reply	other threads:[~2011-02-25 10:39 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-18  8:57 [PATCH V4 0/6] pxa3xx_nand update series set version 4 Lei Wen
2011-02-18  8:57 ` [PATCH 1/6] pxa3xx_nand: make scan procedure more clear Lei Wen
2011-02-18  8:57 ` [PATCH 3/6] pxa3xx_nand: discard wait_for_event, write_cmd, __readid function Lei Wen
2011-02-18  8:57 ` [PATCH 4/6] pxa3xx_nand: unify prepare command Lei Wen
2011-02-18  8:57 ` [PATCH 5/6] pxa3xx_nand: mtd scan id process could be defined by driver itself Lei Wen
2011-02-18  8:57 ` [PATCH 6/6] pxa3xx_nand: clean the keep configure code Lei Wen
2011-02-25 10:39 ` Artem Bityutskiy [this message]
2011-02-28  2:25   ` [PATCH V4 0/6] pxa3xx_nand update series set version 4 Lei Wen
2011-02-28  2:32 ` [PATCH 0/6] pxa3xx_nand update series set version 5 Lei Wen
2011-02-28  2:32 ` [PATCH V5 1/6] pxa3xx_nand: make scan procedure more clear Lei Wen
2011-02-28 13:55   ` Artem Bityutskiy
2011-03-03  3:00     ` Lei Wen
2011-03-03  3:08       ` Lei Wen
2011-03-07  9:49         ` Artem Bityutskiy
2011-03-07 10:00           ` Lei Wen
2011-03-07 10:21             ` Artem Bityutskiy
2011-02-28  2:32 ` [PATCH V5 3/6] pxa3xx_nand: discard wait_for_event, write_cmd, __readid function Lei Wen
2011-02-28  2:32 ` [PATCH V5 4/6] pxa3xx_nand: unify prepare command Lei Wen
2011-02-28  2:32 ` [PATCH V5 6/6] pxa3xx_nand: clean the keep configure code Lei Wen
2011-02-28 13:57   ` Artem Bityutskiy
2011-03-03  3:27     ` Lei Wen
2011-07-08 14:54 ` [PATCH V5 5/6] pxa3xx_nand: mtd scan id process could be defined by driver itself Lei Wen
2011-07-08 14:56 ` [PATCH 2/6] pxa3xx_nand: rework irq logic Lei Wen
2011-07-08 16:03 ` [PATCH V5 " Lei Wen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1298630371.2798.43.camel@localhost \
    --to=dedekind1@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).