From: jean.pihet@newoldbits.com (jean.pihet at newoldbits.com)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] OMAP: use PM QOS for wake-up constraints from I2C
Date: Mon, 28 Feb 2011 18:41:24 +0100 [thread overview]
Message-ID: <1298914884-16468-4-git-send-email-j-pihet@ti.com> (raw)
In-Reply-To: <1298914884-16468-1-git-send-email-j-pihet@ti.com>
From: Jean Pihet <j-pihet@ti.com>
Implements the PM QOS API for the wake-up constraints on the MPU.
Note: the caller shall allocate and store the PM QOS handle for future use
(update/removal of the constraint).
Based on the original patch from Vishwanath,
cf. https://patchwork.kernel.org/patch/327312/
Cc: Vishwanath BS <vishwanath.bs@ti.com>
Signed-off-by: Jean Pihet <j-pihet@ti.com>
---
arch/arm/plat-omap/i2c.c | 22 +++++++++++++++++++++-
1 files changed, 21 insertions(+), 1 deletions(-)
diff --git a/arch/arm/plat-omap/i2c.c b/arch/arm/plat-omap/i2c.c
index 3341ca4..207a320 100644
--- a/arch/arm/plat-omap/i2c.c
+++ b/arch/arm/plat-omap/i2c.c
@@ -117,10 +117,15 @@ static inline int omap1_i2c_add_bus(int bus_id)
* XXX This function is a temporary compatibility wrapper - only
* needed until the I2C driver can be converted to call
* omap_pm_set_max_dev_wakeup_lat() and handle a return code.
+ *
+ * The PM QOS handle is stored in the corresponding omap_device struct.
*/
static void omap_pm_set_max_mpu_wakeup_lat_compat(struct device *dev, long t)
{
- omap_pm_set_max_mpu_wakeup_lat(dev, t);
+ struct omap_device *od = to_omap_device(to_platform_device(dev));
+
+ if (od->pm_qos_request)
+ omap_pm_set_max_mpu_wakeup_lat(od->pm_qos_request, t);
}
static struct omap_device_pm_latency omap_i2c_latency[] = {
@@ -160,11 +165,26 @@ static inline int omap2_i2c_add_bus(int bus_id)
*/
if (cpu_is_omap34xx())
pdata->set_mpu_wkup_lat = omap_pm_set_max_mpu_wakeup_lat_compat;
+
od = omap_device_build(name, bus_id, oh, pdata,
sizeof(struct omap_i2c_bus_platform_data),
omap_i2c_latency, ARRAY_SIZE(omap_i2c_latency), 0);
WARN(IS_ERR(od), "Could not build omap_device for %s\n", name);
+ /* Allocate the PM QOS handle and initialize it */
+ if ((!(IS_ERR(od))) && cpu_is_omap34xx()) {
+ od->pm_qos_request = kzalloc(sizeof(struct pm_qos_request_list),
+ GFP_KERNEL);
+ if (od->pm_qos_request) {
+ pm_qos_add_request(od->pm_qos_request,
+ PM_QOS_CPU_DMA_LATENCY,
+ PM_QOS_DEFAULT_VALUE);
+ } else {
+ WARN(1, "%s: could not reserve memory for "
+ "pm_qos_request\n", __func__);
+ }
+ }
+
return PTR_ERR(od);
}
#else
--
1.7.2.3
prev parent reply other threads:[~2011-02-28 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-28 17:41 [PATCH 0/3] OMAP PM: implement the wake-up latency constraints using PM QOS jean.pihet at newoldbits.com
2011-02-28 17:41 ` [PATCH 1/3] OMAP PM: create a PM layer plugin for the devices wakeup latency constraints jean.pihet at newoldbits.com
2011-02-28 17:41 ` [PATCH 2/3] OMAP: implement MPU and DMA wake-up constraints using PM_QOS jean.pihet at newoldbits.com
2011-02-28 17:41 ` jean.pihet at newoldbits.com [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298914884-16468-4-git-send-email-j-pihet@ti.com \
--to=jean.pihet@newoldbits.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox