linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: mxs/tx28: fix up LCD pads
Date: Sun, 6 Mar 2011 00:27:20 +0800	[thread overview]
Message-ID: <1299342440-30620-1-git-send-email-shawn.guo@freescale.com> (raw)

* In any case, LCD only needs one group of VSYNC, HSYNC, and DOTCLK.
  So remove the redundant and useless one.
* LCD_ENABLE pad should not work as a GPIO for LCD, and there must be
  one pad for ENABLE function.

Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
Hi Lothar, Uwe,

I do not have the schematics of TX28 board, and I'm guessing the fix.
So it really needs your comments here.

Regards,
Shawn

 arch/arm/mach-mxs/mach-tx28.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/arch/arm/mach-mxs/mach-tx28.c b/arch/arm/mach-mxs/mach-tx28.c
index b65e371..16a0059 100644
--- a/arch/arm/mach-mxs/mach-tx28.c
+++ b/arch/arm/mach-mxs/mach-tx28.c
@@ -61,11 +61,7 @@ static const iomux_cfg_t tx28_stk5v3_pads[] __initconst = {
 	MX28_PAD_LCD_RD_E__LCD_VSYNC | LCD_MODE,
 	MX28_PAD_LCD_WR_RWN__LCD_HSYNC | LCD_MODE,
 	MX28_PAD_LCD_RS__LCD_DOTCLK | LCD_MODE,
-	MX28_PAD_LCD_CS__LCD_CS | LCD_MODE,
-	MX28_PAD_LCD_VSYNC__LCD_VSYNC | LCD_MODE,
-	MX28_PAD_LCD_HSYNC__LCD_HSYNC | LCD_MODE,
-	MX28_PAD_LCD_DOTCLK__LCD_DOTCLK | LCD_MODE,
-	MX28_PAD_LCD_ENABLE__GPIO_1_31 | LCD_MODE,
+	MX28_PAD_LCD_CS__LCD_ENABLE | LCD_MODE,
 	MX28_PAD_LCD_RESET__GPIO_3_30 | LCD_MODE,
 	MX28_PAD_PWM0__PWM_0 | LCD_MODE,
 
-- 
1.7.1

             reply	other threads:[~2011-03-05 16:27 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-05 16:27 Shawn Guo [this message]
2011-03-07  7:34 ` [PATCH] ARM: mxs/tx28: fix up LCD pads Sascha Hauer
2011-03-11 16:16 ` Lothar Waßmann
2011-03-15  2:32   ` Shawn Guo
2011-03-15  6:39     ` Lothar Waßmann
2011-03-15  7:33       ` Shawn Guo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299342440-30620-1-git-send-email-shawn.guo@freescale.com \
    --to=shawn.guo@freescale.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).