From: shawn.guo@freescale.com (Shawn Guo)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/3 RESEND] video: mxsfb: smarten the code a little bit
Date: Sun, 6 Mar 2011 14:18:28 +0800 [thread overview]
Message-ID: <1299392308-2551-1-git-send-email-shawn.guo@freescale.com> (raw)
In-Reply-To: <1299341931-30241-2-git-send-email-shawn.guo@freescale.com>
* Fix indentation issue in register definitions
* Add a message for a successful mxsfb_probe, which seems useful
to tell that mxsfb driver is built in and probed successfully
Signed-off-by: Shawn Guo <shawn.guo@freescale.com>
---
drivers/video/mxsfb.c | 17 ++++++++++-------
1 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index a3b1179..9591cb6 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c
@@ -52,11 +52,11 @@
#define LCDC_CTRL 0x00
#define LCDC_CTRL1 0x10
#define LCDC_V4_CTRL2 0x20
-#define LCDC_V3_TRANSFER_COUNT 0x20
-#define LCDC_V4_TRANSFER_COUNT 0x30
-#define LCDC_V4_CUR_BUF 0x40
+#define LCDC_V3_TRANSFER_COUNT 0x20
+#define LCDC_V4_TRANSFER_COUNT 0x30
+#define LCDC_V4_CUR_BUF 0x40
#define LCDC_V4_NEXT_BUF 0x50
-#define LCDC_V3_CUR_BUF 0x30
+#define LCDC_V3_CUR_BUF 0x30
#define LCDC_V3_NEXT_BUF 0x40
#define LCDC_TIMING 0x60
#define LCDC_VDCTRL0 0x70
@@ -71,8 +71,8 @@
#define LCDC_DVICTRL4 0x100
#define LCDC_V4_DATA 0x180
#define LCDC_V3_DATA 0x1b0
-#define LCDC_V4_DEBUG0 0x1d0
-#define LCDC_V3_DEBUG0 0x1f0
+#define LCDC_V4_DEBUG0 0x1d0
+#define LCDC_V3_DEBUG0 0x1f0
#define CTRL_SFTRST (1 << 31)
#define CTRL_CLKGATE (1 << 30)
@@ -832,6 +832,8 @@ static int __devinit mxsfb_probe(struct platform_device *pdev)
mxsfb_enable_controller(fb_info);
}
+ dev_info(&pdev->dev, "initialized\n");
+
return 0;
error_register:
@@ -883,7 +885,8 @@ static struct platform_device_id mxsfb_devtype[] = {
.name = "imx28-fb",
.driver_data = MXSFB_V4,
}, {
- },
+ /* sentinel */
+ }
};
MODULE_DEVICE_TABLE(platform, mxsfb_devtype);
--
1.7.1
next prev parent reply other threads:[~2011-03-06 6:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-05 16:18 A few mxsfb patches Shawn Guo
2011-03-05 16:18 ` [PATCH 1/3] video: mxsfb: smarten the code a little bit Shawn Guo
2011-03-05 16:41 ` Arnd Bergmann
2011-03-06 4:09 ` Shawn Guo
2011-03-06 6:30 ` Shawn Guo
2011-03-06 6:18 ` Shawn Guo [this message]
2011-03-05 16:18 ` [PATCH 2/3] video: mxsfb: fix the incorrect error checking for alloc_pages_exact Shawn Guo
2011-03-05 16:18 ` [PATCH 3/3] video: mxsfb: add DOTCLK polarity configuration support Shawn Guo
2011-04-04 15:04 ` Uwe Kleine-König
2011-04-04 15:42 ` Shawn Guo
2011-04-05 5:53 ` Lothar Waßmann
2011-04-05 6:24 ` Shawn Guo
2011-04-05 7:32 ` Uwe Kleine-König
2011-04-05 6:47 ` [PATCH] video: mxsfb: correct typo 'FAILING' to 'FALLING' Shawn Guo
2011-04-05 7:36 ` Uwe Kleine-König
2011-03-07 7:26 ` A few mxsfb patches Sascha Hauer
2011-03-07 7:45 ` Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1299392308-2551-1-git-send-email-shawn.guo@freescale.com \
--to=shawn.guo@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).