[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

Lets non-standard NAND drivers take advantage of known NAND
chip information.

The initial development of msm nand driver, driver uses the supported
NAND devices information as a hardcoded table. Remove the existing
hardcoded supported flash device table and read the flash device
information from the flash id table which are part of the mtd subsystem.

Signed-off-by: Dima Zavin <dima@android.com>
Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
---
Changes in V2
* Add more description to the commit text.

 drivers/mtd/nand/Kconfig |   10 +++++++---
 1 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
index c895922..782275e 100644
--- a/drivers/mtd/nand/Kconfig
+++ b/drivers/mtd/nand/Kconfig
@@ -1,3 +1,10 @@
+config MTD_NAND_IDS
+	tristate "Include chip ids for known NAND devices."
+	depends on MTD
+	help
+	  Useful for NAND drivers that do not use the NAND subsystem but
+	  still like to take advantage of the known chip information.
+
 config MTD_NAND_ECC
 	tristate
 
@@ -123,9 +130,6 @@ config MTD_NAND_OMAP_PREFETCH_DMA
 	 or in DMA interrupt mode.
 	 Say y for DMA mode or MPU mode will be used
 
-config MTD_NAND_IDS
-	tristate
-
 config MTD_NAND_RICOH
 	tristate "Ricoh xD card reader"
 	default n
-- 
1.7.1.1

--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Artem Bityutskiy]

On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
> 
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.

Why this initial version should be upstream? Why wouldn't you make it
"standard" first?

-- 
Best Regards,
Artem Bityutskiy (????? ????????)

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>> Lets non-standard NAND drivers take advantage of known NAND
>> chip information.
>>
>> The initial development of msm nand driver, driver uses the supported
>> NAND devices information as a hardcoded table. Remove the existing
>> hardcoded supported flash device table and read the flash device
>> information from the flash id table which are part of the mtd subsystem.
>
> Why this initial version should be upstream? Why wouldn't you make it
> "standard" first?
>

Currently we are not fully using the MTD nand subsystem. That's the 
intention author has introduced "non-standard" here!!!

Thanks,
Murali N

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>> Lets non-standard NAND drivers take advantage of known NAND
>>> chip information.
>>>
>>> The initial development of msm nand driver, driver uses the supported
>>> NAND devices information as a hardcoded table. Remove the existing
>>> hardcoded supported flash device table and read the flash device
>>> information from the flash id table which are part of the mtd subsystem.
>>
>> Why this initial version should be upstream? Why wouldn't you make it
>> "standard" first?
>>
>
> Currently we are not fully using the MTD nand subsystem. That's the
> intention author has introduced "non-standard" here!!!
>
> Thanks,
> Murali N
>

Any reviews comments on this change?

Thanks,
Murali N

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Artem Bityutskiy]

On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
> > On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
> >> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
> >>> Lets non-standard NAND drivers take advantage of known NAND
> >>> chip information.
> >>>
> >>> The initial development of msm nand driver, driver uses the supported
> >>> NAND devices information as a hardcoded table. Remove the existing
> >>> hardcoded supported flash device table and read the flash device
> >>> information from the flash id table which are part of the mtd subsystem.
> >>
> >> Why this initial version should be upstream? Why wouldn't you make it
> >> "standard" first?
> >>
> >
> > Currently we are not fully using the MTD nand subsystem. That's the
> > intention author has introduced "non-standard" here!!!
> >
> > Thanks,
> > Murali N
> >
> 
> Any reviews comments on this change?

No, I think you should "sell" your driver better than that. Indeed,

Q: "Why this initial version should be upstream? Why wouldn't you make
it "standard" first?"
A: Currently we are not fully using the MTD nand subsystem. That's the
intention author has introduced "non-standard" here!!!

-- 
Best Regards,
Artem Bityutskiy (????? ????????)

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

On 3/21/2011 12:42 PM, Artem Bityutskiy wrote:
> On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
>> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
>>> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>>>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>>>> Lets non-standard NAND drivers take advantage of known NAND
>>>>> chip information.
>>>>>
>>>>> The initial development of msm nand driver, driver uses the supported
>>>>> NAND devices information as a hardcoded table. Remove the existing
>>>>> hardcoded supported flash device table and read the flash device
>>>>> information from the flash id table which are part of the mtd subsystem.
>>>>
>>>> Why this initial version should be upstream? Why wouldn't you make it
>>>> "standard" first?
>>>>
>>>
>>> Currently we are not fully using the MTD nand subsystem. That's the
>>> intention author has introduced "non-standard" here!!!
>>>
>>> Thanks,
>>> Murali N
>>>
>>
>> Any reviews comments on this change?
>
> No, I think you should "sell" your driver better than that. Indeed,
>
> Q: "Why this initial version should be upstream? Why wouldn't you make
> it "standard" first?"
> A: Currently we are not fully using the MTD nand subsystem. That's the
> intention author has introduced "non-standard" here!!!
>

The driver (msm_nand.c) is in align to MTD specification.
But this commit text is bit misleading, initially the driver
didn't make use of nand flash devices information from the
flash id table which are part of the MTD subsystem. Hence
we have enabled this config option to make use of it.

Thanks,
Murali N

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

On 3/21/2011 1:28 PM, Murali Nalajala wrote:
> On 3/21/2011 12:42 PM, Artem Bityutskiy wrote:
>> On Mon, 2011-03-21 at 12:09 +0530, Murali Nalajala wrote:
>>> On 3/8/2011 11:11 PM, Murali Nalajala wrote:
>>>> On 3/8/2011 12:50 AM, Artem Bityutskiy wrote:
>>>>> On Tue, 2011-03-08 at 05:38 +0530, Murali Nalajala wrote:
>>>>>> Lets non-standard NAND drivers take advantage of known NAND
>>>>>> chip information.
>>>>>>
>>>>>> The initial development of msm nand driver, driver uses the supported
>>>>>> NAND devices information as a hardcoded table. Remove the existing
>>>>>> hardcoded supported flash device table and read the flash device
>>>>>> information from the flash id table which are part of the mtd
>>>>>> subsystem.
>>>>>
>>>>> Why this initial version should be upstream? Why wouldn't you make it
>>>>> "standard" first?
>>>>>
>>>>
>>>> Currently we are not fully using the MTD nand subsystem. That's the
>>>> intention author has introduced "non-standard" here!!!
>>>>
>>>> Thanks,
>>>> Murali N
>>>>
>>>
>>> Any reviews comments on this change?
>>
>> No, I think you should "sell" your driver better than that. Indeed,
>>
>> Q: "Why this initial version should be upstream? Why wouldn't you make
>> it "standard" first?"
>> A: Currently we are not fully using the MTD nand subsystem. That's the
>> intention author has introduced "non-standard" here!!!
>>
>
> The driver (msm_nand.c) is in align to MTD specification.
> But this commit text is bit misleading, initially the driver
> didn't make use of nand flash devices information from the
> flash id table which are part of the MTD subsystem. Hence
> we have enabled this config option to make use of it.
>
> Thanks,
> Murali N
>

Hi,
Still you have any issues/comments?

Thanks,
Murali N

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Artem Bityutskiy]

On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
> Still you have any issues/comments?

No, not so far, just have not time now to look closer.


-- 
Best Regards,
Artem Bityutskiy (????? ????????)

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Murali Nalajala]

On 3/22/2011 1:41 PM, Artem Bityutskiy wrote:
> On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
>> Still you have any issues/comments?
>
> No, not so far, just have not time now to look closer.
>
>
Did anybody got a chance to go through the patch?

Thanks,
Murali N

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Artem Bityutskiy]

On Wed, 2011-04-06 at 10:08 +0530, Murali Nalajala wrote:
> On 3/22/2011 1:41 PM, Artem Bityutskiy wrote:
> > On Tue, 2011-03-22 at 12:11 +0530, Murali Nalajala wrote:
> >> Still you have any issues/comments?
> >
> > No, not so far, just have not time now to look closer.
> >
> >
> Did anybody got a chance to go through the patch?

Could you start with trying to get an ack or reviewed-by from some
maintainer form Codeaurora, e.g., David Brown? Unfortunately, MTD
community does not have enough people who'd actively review other's
work.

-- 
Best Regards,
Artem Bityutskiy (????? ????????)

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[Dima Zavin]

Acked-by: Dima Zavin <dima@android.com>

On Mon, Mar 7, 2011 at 4:08 PM, Murali Nalajala <mnalajal@codeaurora.org> wrote:
> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
>
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.
>
> Signed-off-by: Dima Zavin <dima@android.com>
> Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>
> ---
> Changes in V2
> * Add more description to the commit text.
>
> ?drivers/mtd/nand/Kconfig | ? 10 +++++++---
> ?1 files changed, 7 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index c895922..782275e 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -1,3 +1,10 @@
> +config MTD_NAND_IDS
> + ? ? ? tristate "Include chip ids for known NAND devices."
> + ? ? ? depends on MTD
> + ? ? ? help
> + ? ? ? ? Useful for NAND drivers that do not use the NAND subsystem but
> + ? ? ? ? still like to take advantage of the known chip information.
> +
> ?config MTD_NAND_ECC
> ? ? ? ?tristate
>
> @@ -123,9 +130,6 @@ config MTD_NAND_OMAP_PREFETCH_DMA
> ? ? ? ? or in DMA interrupt mode.
> ? ? ? ? Say y for DMA mode or MPU mode will be used
>
> -config MTD_NAND_IDS
> - ? ? ? tristate
> -
> ?config MTD_NAND_RICOH
> ? ? ? ?tristate "Ricoh xD card reader"
> ? ? ? ?default n
> --
> 1.7.1.1
>
> --
> Sent by a consultant of the Qualcomm Innovation Center, Inc.
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
>
>

[PATCH V2 1/2] mtd: nand: Allow NAND chip ids to be included standalone.

[David Brown]

On Mon, Mar 07 2011, Murali Nalajala wrote:

> Lets non-standard NAND drivers take advantage of known NAND
> chip information.
>
> The initial development of msm nand driver, driver uses the supported
> NAND devices information as a hardcoded table. Remove the existing
> hardcoded supported flash device table and read the flash device
> information from the flash id table which are part of the mtd subsystem.
>
> Signed-off-by: Dima Zavin <dima@android.com>
> Signed-off-by: Murali Nalajala <mnalajal@codeaurora.org>

Acked-by: David Brown <davidb@codeaurora.org>

-- 
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.