linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 4/7] ARM: s5pv310: update IRQ combiner to use chained entry/exit functions
Date: Tue,  8 Mar 2011 17:13:22 +0000	[thread overview]
Message-ID: <1299604405-12960-5-git-send-email-will.deacon@arm.com> (raw)
In-Reply-To: <1299604405-12960-1-git-send-email-will.deacon@arm.com>

This patch updates the IRQ combiner chained IRQ handler code to use the
chained IRQ enter/exit functions in order to function correctly on
primary controllers with different methods of flow control.

This is required for the GIC to move to fasteoi interrupt handling.

Cc: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
---
 arch/arm/mach-s5pv310/irq-combiner.c |    6 ++----
 1 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/arch/arm/mach-s5pv310/irq-combiner.c b/arch/arm/mach-s5pv310/irq-combiner.c
index 1ea4a9e..d5cf33e 100644
--- a/arch/arm/mach-s5pv310/irq-combiner.c
+++ b/arch/arm/mach-s5pv310/irq-combiner.c
@@ -59,8 +59,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
 	unsigned int cascade_irq, combiner_irq;
 	unsigned long status;
 
-	/* primary controller ack'ing */
-	chip->irq_ack(&desc->irq_data);
+	chained_irq_enter(chip, desc);
 
 	spin_lock(&irq_controller_lock);
 	status = __raw_readl(chip_data->base + COMBINER_INT_STATUS);
@@ -79,8 +78,7 @@ static void combiner_handle_cascade_irq(unsigned int irq, struct irq_desc *desc)
 		generic_handle_irq(cascade_irq);
 
  out:
-	/* primary controller unmasking */
-	chip->irq_unmask(&desc->irq_data);
+	chained_irq_exit(chip, desc);
 }
 
 static struct irq_chip combiner_chip = {
-- 
1.7.0.4

  parent reply	other threads:[~2011-03-08 17:13 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-08 17:13 [PATCH v3 0/7] Migrate GIC to fasteoi flow control Will Deacon
2011-03-08 17:13 ` [PATCH 1/7] ARM: irq: introduce entry and exit functions for chained handlers Will Deacon
2011-03-11 16:33   ` Thomas Gleixner
2011-03-11 16:56     ` Will Deacon
2011-03-11 19:19       ` Thomas Gleixner
2011-03-14 13:04         ` Will Deacon
2011-03-08 17:13 ` [PATCH 2/7] ARM: omap: update GPIO chained IRQ handler to use entry/exit functions Will Deacon
2011-03-08 17:13 ` [PATCH 3/7] ARM: tegra: " Will Deacon
2011-03-08 17:13 ` Will Deacon [this message]
2011-03-08 17:13 ` [PATCH 5/7] ARM: msm: " Will Deacon
2011-03-08 17:13 ` [PATCH 6/7] ARM: nmk: update GPIO chained IRQ handler to " Will Deacon
2011-03-08 17:13 ` [PATCH 7/7] ARM: gic: use handle_fasteoi_irq for SPIs Will Deacon
2011-03-11 15:59 ` [PATCH v3 0/7] Migrate GIC to fasteoi flow control Will Deacon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299604405-12960-5-git-send-email-will.deacon@arm.com \
    --to=will.deacon@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).