From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 99B5CC27C53 for ; Thu, 13 Jun 2024 02:54:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=uNmwMejHmNOh8I+RARUVaSfw/MphRluAD/hWf+7EyHM=; b=mmLAvuEFLR1wn3Fyvg4an21LyT fBYID8lm5QYF/OstOmgLKoSqg7bNqUpJ5F2uV/1f6VqRgyK24iG63YtKgErYJmBRCJXAnAjbNYFma ro+9ZrcTlc2BLr0a3LLVebgGR5Li65kVDACfju4jlO2keT5yKm0klwAYyfejq84bD6n1oic59QC56 AjI1hQ+AA/1EgZ0lQo5QmVt3WxlpKts64j3aed9e0RHokHb82DV9u9jjMJjNyTJxcnSX4WLqM3gQh +2As9ZpDWpyIyv0m010bU538gliaHxUaIwqdxhPiTkZ2o86TZkfzgTxwcd7YA/6/0znF6iFAyfLWO kTrgJfhg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHabX-0000000EuL7-1Km6; Thu, 13 Jun 2024 02:54:23 +0000 Received: from mail-pf1-x431.google.com ([2607:f8b0:4864:20::431]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sHabT-0000000EuJf-0bKS for linux-arm-kernel@lists.infradead.org; Thu, 13 Jun 2024 02:54:21 +0000 Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-705c739b878so756529b3a.1 for ; Wed, 12 Jun 2024 19:54:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718247256; x=1718852056; darn=lists.infradead.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=uNmwMejHmNOh8I+RARUVaSfw/MphRluAD/hWf+7EyHM=; b=T/UqHUSPk3OGBc3k0ocs6aDhZSXSamgDapFEJGCUf3O2UI24tS/gNrgAVKvILSY/LW L9JWIKfRUiFJBflJU3bKDStNpxhhgWCtrlfUdp+/ij9Pz+K9Du0ZSUwia6ij0+HaW/fS 9tQGcunD9gebXUAodPfIfgBOI1XYijC2m+9lzCETw4rc3ai2orZvjenUQefDqktU0Vol 7KZPpBuWw/HyhiTDMf3ZC/6DaZbQT3FoqsulnMnpqzYe24ApNQXS9ve1v3w5B6R35rAw VVsFUr/EqEqI4+dwuirpJadEjBsG8C3oJuKmF4pSJAvv9K+I8znYb3nRn1wdxvTW68JY mv9Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718247256; x=1718852056; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uNmwMejHmNOh8I+RARUVaSfw/MphRluAD/hWf+7EyHM=; b=q7rKQAyMxdxNJTKHeuI7WOyT5cM8FManVook0oHpEMQL47dktP4dZrMONTVGZFAO8r 3bFW9vZYrJFSo4VoD/pqKe+h8kEftM60qO2kZG0EUN/QSbntk5mm/UxaK2r/bL2p9BYS hkhuBpUmpfxqz1GRlcLuAQgplsyPa29xW0YfbjUt1kqK4hyD4ZP1F/l5TVut3gZcMJGX 8/1Qo5FBOF/DBkz7N0jx4E3Ka+fQWEvQioCFycIQzRlzxO+OwaoneRpXvVf0RATGiiZp KaIv0J17zJr8GCd/GitCCiBreOyQKI1FpYalyaeqf8N5NKeWOwePG6yI4q+bLeqeXUDT R3gQ== X-Forwarded-Encrypted: i=1; AJvYcCUhnb8TL4AFaGi4dofr9/0Kg0805NHBkDry0psVTF2//t/r6+izxfbZZWOohgcd/kdKU5b2dtcic44dvZnO11iFCAhKKTuxnYLNTyPOD7xMPy0o4xc= X-Gm-Message-State: AOJu0Yztxa5mQhEoBOknQbW9zF6Tg1Tm4QNke05TKLlCrdJL3hdteYoY gj7zo0fczrRR2gsO/39FarM2qiI1/lsFGcRC80I9ajdxL9qDnqDr4WDdkg== X-Google-Smtp-Source: AGHT+IGbL59FB/N0ejH67gB7kJ3RteUZ72f6jaqWjh8P39UHzwD8iyB1oIQqw4Is9dSdRe11OIbXhg== X-Received: by 2002:a05:6a20:7485:b0:1b6:dc44:8211 with SMTP id adf61e73a8af0-1b8bef9e17emr2373909637.1.1718247255601; Wed, 12 Jun 2024 19:54:15 -0700 (PDT) Received: from [172.19.1.47] (60-250-192-107.hinet-ip.hinet.net. [60.250.192.107]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-705cc925fe7sm296762b3a.19.2024.06.12.19.54.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 12 Jun 2024 19:54:15 -0700 (PDT) Message-ID: <12baa918-2066-47b1-ab88-27d1dc6041b2@gmail.com> Date: Thu, 13 Jun 2024 10:54:12 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] tty: serial: ma35d1: Add a NULL check for of_node To: Greg KH Cc: dan.carpenter@linaro.org, jirislaby@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, Jacky Huang References: <20240611092251.159149-1-ychuang570808@gmail.com> <2024061118-sycamore-leggings-05a9@gregkh> <73d2167a-84ee-40a4-a68d-ba25229ff8ce@gmail.com> <2024061226-laborious-jubilance-8df8@gregkh> Content-Language: en-US From: Jacky Huang In-Reply-To: <2024061226-laborious-jubilance-8df8@gregkh> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240612_195419_230562_9B6ACD3B X-CRM114-Status: GOOD ( 20.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Dear Greg, On 2024/6/12 下午 03:23, Greg KH wrote: > On Wed, Jun 12, 2024 at 08:43:54AM +0800, Jacky Huang wrote: >> Dear Greg, >> >> >> On 2024/6/11 下午 07:11, Greg KH wrote: >>> On Tue, Jun 11, 2024 at 09:22:51AM +0000, Jacky Huang wrote: >>>> From: Jacky Huang >>>> >>>> The pdev->dev.of_node can be NULL if the "serial" node is absent. >>>> Add a NULL check to return an error in such cases. >>>> >>>> Signed-off-by: Jacky Huang >>>> --- >>>> drivers/tty/serial/ma35d1_serial.c | 13 +++++++------ >>>> 1 file changed, 7 insertions(+), 6 deletions(-) >>>> >>>> diff --git a/drivers/tty/serial/ma35d1_serial.c b/drivers/tty/serial/ma35d1_serial.c >>>> index 19f0a305cc43..3b4206e815fe 100644 >>>> --- a/drivers/tty/serial/ma35d1_serial.c >>>> +++ b/drivers/tty/serial/ma35d1_serial.c >>>> @@ -688,12 +688,13 @@ static int ma35d1serial_probe(struct platform_device *pdev) >>>> struct uart_ma35d1_port *up; >>>> int ret = 0; >>>> - if (pdev->dev.of_node) { >>>> - ret = of_alias_get_id(pdev->dev.of_node, "serial"); >>>> - if (ret < 0) { >>>> - dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); >>>> - return ret; >>>> - } >>>> + if (!pdev->dev.of_node) >>>> + return -ENODEV; >>>> + >>>> + ret = of_alias_get_id(pdev->dev.of_node, "serial"); >>>> + if (ret < 0) { >>>> + dev_err(&pdev->dev, "failed to get alias/pdev id, errno %d\n", ret); >>>> + return ret; >>>> } >>>> up = &ma35d1serial_ports[ret]; >>>> up->port.line = ret; >>> What commit id does this fix? >>> >>> thanks, >>> >>> greg k-h >> This patch fix the in tree ma35d1 serial driver. >> The last commit for ma35d1_serial.c is >> '6b64f8e360c00f180cffa1806095cdd2abc55b16'. > That is obviously not the commit that causes this problem, which is what > I was looking for here. Shouldn't you include a "Fixes:" line if this > is resolving a bug? > > thanks, > > greg k-h I got it. The  commit that cause this problem is '930cbf92db01'. And I will send v2 patch with the "Fixes:" line. Fixes: 930cbf92db01 ("tty: serial: Add Nuvoton ma35d1 serial driver support") Best Regards, Jacky Huang