From: "Raghavendra, Vignesh" <vigneshr@ti.com>
To: Siddharth Vadapalli <s-vadapalli@ti.com>, <tjoseph@cadence.com>,
<lpieralisi@kernel.org>, <robh@kernel.org>, <kw@linux.com>,
<bhelgaas@google.com>, <nadeem@cadence.com>
Cc: <linux-pci@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>, <srk@ti.com>, <nm@ti.com>
Subject: Re: [PATCH v2] PCI: cadence: Fix Gen2 Link Retraining process
Date: Wed, 29 Mar 2023 20:11:25 +0530 [thread overview]
Message-ID: <12c89cb8-8cea-df6a-7650-fa3059bf5a5b@ti.com> (raw)
In-Reply-To: <20230315070800.1615527-1-s-vadapalli@ti.com>
Hi Lorenzo, Bjorn,
On 3/15/2023 12:38 PM, Siddharth Vadapalli wrote:
> The Link Retraining process is initiated to account for the Gen2 defect in
> the Cadence PCIe controller in J721E SoC. The errata corresponding to this
> is i2085, documented at:
> https://www.ti.com/lit/er/sprz455c/sprz455c.pdf
>
> The existing workaround implemented for the errata waits for the Data Link
> initialization to complete and assumes that the link retraining process
> at the Physical Layer has completed. However, it is possible that the
> Physical Layer training might be ongoing as indicated by the
> PCI_EXP_LNKSTA_LT bit in the PCI_EXP_LNKSTA register.
>
> Fix the existing workaround, to ensure that the Physical Layer training
> has also completed, in addition to the Data Link initialization.
>
> Fixes: 4740b969aaf5 ("PCI: cadence: Retrain Link to work around Gen2 training defect")
> Signed-off-by: Siddharth Vadapalli <s-vadapalli@ti.com>
> Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>
> ---
> Changes from v1:
> 1. Collect Reviewed-by tag from Vignesh Raghavendra.
> 2. Rebase on next-20230315.
>
> v1:
> https://lore.kernel.org/r/20230102075656.260333-1-s-vadapalli@ti.com
>
> .../controller/cadence/pcie-cadence-host.c | 27 +++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
Wondering do one of you be pulling this patch in? This patch was never
picked for 6.3-rc1 merge cycle... Just want to make sure
pcie-cadence*.c and pci-j721e.c patches have a path to reach pci tree.
[...]
Regards
Vignesh
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-29 14:43 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-15 7:08 [PATCH v2] PCI: cadence: Fix Gen2 Link Retraining process Siddharth Vadapalli
2023-03-29 14:41 ` Raghavendra, Vignesh [this message]
2023-03-29 17:08 ` Bjorn Helgaas
2023-03-30 4:22 ` Siddharth Vadapalli
2023-03-30 17:02 ` Bjorn Helgaas
2023-04-18 3:49 ` Siddharth Vadapalli
2023-04-21 8:57 ` Lorenzo Pieralisi
2023-03-30 8:45 ` Vignesh Raghavendra
2023-04-21 9:09 ` Lorenzo Pieralisi
[not found] <0ef69859-7ff9-1988-3c7e-692d8692b59f@ti.com>
2023-06-06 16:20 ` Bjorn Helgaas
2023-06-07 9:17 ` Siddharth Vadapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12c89cb8-8cea-df6a-7650-fa3059bf5a5b@ti.com \
--to=vigneshr@ti.com \
--cc=bhelgaas@google.com \
--cc=kw@linux.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lpieralisi@kernel.org \
--cc=nadeem@cadence.com \
--cc=nm@ti.com \
--cc=robh@kernel.org \
--cc=s-vadapalli@ti.com \
--cc=srk@ti.com \
--cc=tjoseph@cadence.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox