linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: matthias.bgg@gmail.com (Matthias Brugger)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC
Date: Wed, 12 Jul 2017 16:50:53 +0200	[thread overview]
Message-ID: <12f23fb1-a145-bdf0-54c8-c2818ba75d9d@gmail.com> (raw)
In-Reply-To: <1499741386.12408.11.camel@mtksdaap41>

Hi Eddie,

On 07/11/2017 04:49 AM, Eddie Huang wrote:
> Hi Sean,
> 
> On Mon, 2017-07-10 at 22:23 +0800, sean.wang at mediatek.com wrote:
>> From: Sean Wang <sean.wang@mediatek.com>
>>
>> MT2701/MT7623 is a 32-bit ARMv7 based quad-core (4 * Cortex-A7) with
>> single cluster and this hardware is also compatible with the existing
>> driver through enabling CPU frequency feature with operating-points-v2
>> bindings. Also, this driver actually supports all MediaTek SoCs, the
>> Kconfig menu entry and file name itself should be updated with more
>> generic name to drop "MT8173"
>>
>> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
>> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>> Reviewed-by: Jean Delvare <jdelvare@suse.de>
>> ---
>>   drivers/cpufreq/Kconfig.arm                              | 7 +++----
>>   drivers/cpufreq/Makefile                                 | 2 +-
>>   drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} | 2 ++
>>   3 files changed, 6 insertions(+), 5 deletions(-)
>>   rename drivers/cpufreq/{mt8173-cpufreq.c => mediatek-cpufreq.c} (99%)
>>
> 
> As Viresh mentioned, there are already many drivers use "mtk" as
> filename prefix or postfix.To align with those files, I suggest use
> mtk-cpufreq.c.I think there are not too many values to change all "mtk-"
> to "mediatek-", but it is worth to have the same naming rule for
> mediatek upstream driver.
> 

In the last submission Jean proposed to change all file names from 
mtk-*.[ch] to mediatek-*.[ch] as this will cause less confusion.

Viresh are you OK with that approach or do you prefer that we stay with 
mtk prefix? I think it makes sense to have a unique prefix and resolve 
the situation we now have with source files and Kconfig options.
But TBH I have no strong feeling for any of the two prefixes.

Regards,
Matthias

  reply	other threads:[~2017-07-12 14:50 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-10 14:23 [PATCH v4 0/3] some fixups for MediaTek cpufreq driver sean.wang at mediatek.com
2017-07-10 14:23 ` [PATCH v4 1/3] cpufreq: mediatek: Add support of cpufreq to MT2701/MT7623 SoC sean.wang at mediatek.com
2017-07-11  2:49   ` Eddie Huang
2017-07-12 14:50     ` Matthias Brugger [this message]
2017-07-13  3:16       ` Viresh Kumar
2017-07-13  3:54         ` Eddie Huang
2017-07-17  8:05           ` Jean Delvare
2017-07-17  8:06   ` Jean Delvare
2017-07-10 14:23 ` [PATCH v4 2/3] dt-bindings: cpufreq: move MediaTek cpufreq dt-bindings document to proper place sean.wang at mediatek.com
2017-07-10 14:23 ` [PATCH v4 3/3] dt-bindings: cpufreq: enhance MediaTek cpufreq dt-binding document sean.wang at mediatek.com
2017-07-17  6:16 ` [PATCH v4 0/3] some fixups for MediaTek cpufreq driver Sean Wang
2017-07-17  7:35   ` Viresh Kumar
2017-07-17 11:33     ` Rafael J. Wysocki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=12f23fb1-a145-bdf0-54c8-c2818ba75d9d@gmail.com \
    --to=matthias.bgg@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).