From: "quanyang.wang" <quanyang.wang@windriver.com>
To: Michal Simek <michal.simek@xilinx.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328
Date: Mon, 8 Mar 2021 18:15:47 +0800 [thread overview]
Message-ID: <12fe8fa5-1014-634a-940d-d33d5b7bbd6e@windriver.com> (raw)
In-Reply-To: <a577fa2d-eb6c-aada-d460-35304af7b18d@xilinx.com>
Hi Michal,
On 3/8/21 4:47 PM, Michal Simek wrote:
> Hi,
>
> On 3/8/21 9:35 AM, Laurent Pinchart wrote:
>> Hi Quanyang,
>>
>> Thank you for the patch.
>>
>> On Mon, Mar 08, 2021 at 03:08:43PM +0800, quanyang.wang@windriver.com wrote:
>>> From: Quanyang Wang <quanyang.wang@windriver.com>
>>>
>>> The function of_i2c_get_board_info will call of_modalias_node to check
>>> if a device_node contains "compatible" string. So let's assign the
>>> proper string "silabs,si5328" to clock-generator@69's compatible
>>> property to eliminate the error info as below:
>> As far as I can tell, "silabs,si5328" isn't documented in
>> Documentation/devicetree/bindings/. We need DT bindings before making
>> use of the compatible string.
>>
> the second option is to remove/comment this node.
Thank you for your suggestion.
I will send a new patch to delete these nodes and add some comments there.
Best Regards
Quanyang
>
> Thanks,
> Michal
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-08 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-08 7:08 [PATCH] arm64: dts: zynqmp: Add compatible strings for si5328 quanyang.wang
2021-03-08 8:35 ` Laurent Pinchart
2021-03-08 8:47 ` Michal Simek
2021-03-08 10:15 ` quanyang.wang [this message]
2021-03-08 10:12 ` quanyang.wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=12fe8fa5-1014-634a-940d-d33d5b7bbd6e@windriver.com \
--to=quanyang.wang@windriver.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.simek@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).