From: fabio.estevam@freescale.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/2] ARM: mx5/babbage: Remove unneeded gpio_set_value call
Date: Mon, 14 Mar 2011 15:21:08 -0300 [thread overview]
Message-ID: <1300126869-14587-1-git-send-email-fabio.estevam@freescale.com> (raw)
gpio_direction_output has already set the port at low logical level, so it is not needed
to call gpio_set_value to set the port to 0 again.
Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
arch/arm/mach-mx5/board-mx51_babbage.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
index b2ecd19..9b6c868 100644
--- a/arch/arm/mach-mx5/board-mx51_babbage.c
+++ b/arch/arm/mach-mx5/board-mx51_babbage.c
@@ -234,7 +234,6 @@ static inline void babbage_fec_reset(void)
return;
}
gpio_direction_output(BABBAGE_FEC_PHY_RESET, 0);
- gpio_set_value(BABBAGE_FEC_PHY_RESET, 0);
msleep(1);
gpio_set_value(BABBAGE_FEC_PHY_RESET, 1);
}
--
1.6.0.4
next reply other threads:[~2011-03-14 18:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-14 18:21 Fabio Estevam [this message]
2011-03-14 18:21 ` [PATCH 2/2] ARM: mx5/mx53_evk: Remove unneeded gpio_set_value call Fabio Estevam
2011-03-15 9:06 ` Uwe Kleine-König
2011-03-15 9:41 ` Julia Lawall
2011-03-15 9:49 ` Uwe Kleine-König
2011-03-15 10:19 ` Julia Lawall
2011-03-15 10:29 ` Wolfram Sang
2011-03-16 8:33 ` Uwe Kleine-König
2011-03-16 9:15 ` Julia Lawall
2011-03-16 14:19 ` Fabio Estevam
2011-03-20 17:56 ` Julia Lawall
2011-03-20 19:24 ` Wolfram Sang
2011-03-20 20:51 ` Julia Lawall
2011-03-20 21:30 ` Wolfram Sang
2011-03-20 21:42 ` Julia Lawall
2011-03-20 21:04 ` Julia Lawall
2011-03-21 7:43 ` Grant Likely
2011-03-21 7:59 ` Julia Lawall
2011-03-21 7:48 ` Grant Likely
2011-03-21 8:01 ` Julia Lawall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300126869-14587-1-git-send-email-fabio.estevam@freescale.com \
--to=fabio.estevam@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).