linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: mx5/babbage: Remove unneeded gpio_set_value call
@ 2011-03-14 18:21 Fabio Estevam
  2011-03-14 18:21 ` [PATCH 2/2] ARM: mx5/mx53_evk: " Fabio Estevam
  0 siblings, 1 reply; 20+ messages in thread
From: Fabio Estevam @ 2011-03-14 18:21 UTC (permalink / raw)
  To: linux-arm-kernel

gpio_direction_output has already set the port at low logical level, so it is not needed
to call gpio_set_value to set the port to 0 again.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx51_babbage.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx51_babbage.c b/arch/arm/mach-mx5/board-mx51_babbage.c
index b2ecd19..9b6c868 100644
--- a/arch/arm/mach-mx5/board-mx51_babbage.c
+++ b/arch/arm/mach-mx5/board-mx51_babbage.c
@@ -234,7 +234,6 @@ static inline void babbage_fec_reset(void)
 		return;
 	}
 	gpio_direction_output(BABBAGE_FEC_PHY_RESET, 0);
-	gpio_set_value(BABBAGE_FEC_PHY_RESET, 0);
 	msleep(1);
 	gpio_set_value(BABBAGE_FEC_PHY_RESET, 1);
 }
-- 
1.6.0.4

^ permalink raw reply related	[flat|nested] 20+ messages in thread

end of thread, other threads:[~2011-03-21  8:01 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-14 18:21 [PATCH 1/2] ARM: mx5/babbage: Remove unneeded gpio_set_value call Fabio Estevam
2011-03-14 18:21 ` [PATCH 2/2] ARM: mx5/mx53_evk: " Fabio Estevam
2011-03-15  9:06   ` Uwe Kleine-König
2011-03-15  9:41     ` Julia Lawall
2011-03-15  9:49       ` Uwe Kleine-König
2011-03-15 10:19         ` Julia Lawall
2011-03-15 10:29           ` Wolfram Sang
2011-03-16  8:33           ` Uwe Kleine-König
2011-03-16  9:15             ` Julia Lawall
2011-03-16 14:19             ` Fabio Estevam
2011-03-20 17:56             ` Julia Lawall
2011-03-20 19:24               ` Wolfram Sang
2011-03-20 20:51                 ` Julia Lawall
2011-03-20 21:30                   ` Wolfram Sang
2011-03-20 21:42                     ` Julia Lawall
2011-03-20 21:04                 ` Julia Lawall
2011-03-21  7:43                   ` Grant Likely
2011-03-21  7:59                     ` Julia Lawall
2011-03-21  7:48           ` Grant Likely
2011-03-21  8:01             ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).