linux-arm-kernel.lists.infradead.org archive mirror
 help / color / mirror / Atom feed
From: festevam@gmail.com (Fabio Estevam)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/4] ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset
Date: Wed, 16 Mar 2011 22:52:33 -0300	[thread overview]
Message-ID: <1300326754-4629-3-git-send-email-festevam@gmail.com> (raw)
In-Reply-To: <1300326754-4629-2-git-send-email-festevam@gmail.com>

Current code inside mx53_evk_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets 
the GPIO value via gpio_set_value right after. This is not needed. 

By using gpio_request_one it is possible to set the direction and initial value in one shot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
---
 arch/arm/mach-mx5/board-mx53_evk.c |    5 ++---
 1 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/arch/arm/mach-mx5/board-mx53_evk.c b/arch/arm/mach-mx5/board-mx53_evk.c
index 7b5735c..8ca55c0 100644
--- a/arch/arm/mach-mx5/board-mx53_evk.c
+++ b/arch/arm/mach-mx5/board-mx53_evk.c
@@ -82,13 +82,12 @@ static inline void mx53_evk_fec_reset(void)
 	int ret;
 
 	/* reset FEC PHY */
-	ret = gpio_request(SMD_FEC_PHY_RST, "fec-phy-reset");
+	ret = gpio_request_one(SMD_FEC_PHY_RST, GPIOF_OUT_INIT_LOW,
+							"fec-phy-reset");
 	if (ret) {
 		printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
 		return;
 	}
-	gpio_direction_output(SMD_FEC_PHY_RST, 0);
-	gpio_set_value(SMD_FEC_PHY_RST, 0);
 	msleep(1);
 	gpio_set_value(SMD_FEC_PHY_RST, 1);
 }
-- 
1.6.0.4

  reply	other threads:[~2011-03-17  1:52 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17  1:52 [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Fabio Estevam
2011-03-17  1:52 ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Fabio Estevam
2011-03-17  1:52   ` Fabio Estevam [this message]
2011-03-17  1:52     ` [PATCH 4/4] ARM: mx5/mx53_evk: Make the reset pin name more meaningful Fabio Estevam
2011-03-17  7:55   ` [PATCH 2/4] ARM: mx5/babbage: Use gpio_request_one in babbage_usbhub_reset Uwe Kleine-König
2011-03-17  7:57 ` [PATCH 1/4] ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1300326754-4629-3-git-send-email-festevam@gmail.com \
    --to=festevam@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).