From: ithamar.adema@team-embedded.nl (Ithamar R. Adema)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 7/9] lpc2k: Add EmbeddedArtists LPC2478 Developer's Kit board
Date: Thu, 17 Mar 2011 23:18:35 +0100 [thread overview]
Message-ID: <1300400315.2138.103.camel@team-embedded-2> (raw)
In-Reply-To: <083DF309106F364B939360100EC290F80B15AC2B39@eu1rdcrdc1wx030.exi.nxp.com>
On Thu, 2011-03-17 at 23:07 +0100, Kevin Wells wrote:
> > +
> > +#define EXTPOLAR 0x14c
> > +
> > +static unsigned long mfp_cfgs[] = {
>
> Should this be initdata?
Yes, good catch!
> > +MACHINE_START(LPC2478OEM, "Embedded Artists LPC2478 OEM Board")
>
> Just a nit, but the machine ID should probably be unique to this
> board and not the 2478, ie EA2478OEM. If someone else releases a
> LPC2478 based board, it can't use this same id. This would apply
> to the filename too (lpc2478oem.c) - the name is somewhat generic
> and might be better named something like plat-ea2478oem.c.
True, a more concise name there would be helpful. It is a bit of a
mixture since the LPC2478OEM is just the CPU board, and the 'Developer's
Kit' includes a baseboard with peripheral devices.
I'll come up with a better name for it, it will just require another
board registration and update of arch/arm/tools/mach-types :(
Regards,
Ithamar.
next prev parent reply other threads:[~2011-03-17 22:18 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-17 15:54 [PATCH 0/9] Support for NXP LPC2K SoCs Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 1/9] lpc2k: Core support Ithamar R. Adema
2011-03-17 21:26 ` Jamie Iles
2011-03-17 21:32 ` Vitaly Wool
2011-03-17 21:50 ` Ithamar R. Adema
2011-03-17 22:08 ` Kevin Wells
2011-03-17 22:25 ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 2/9] lpc2k: Exception vector handling Ithamar R. Adema
2011-03-17 16:18 ` Uwe Kleine-König
2011-03-17 16:28 ` Ithamar R. Adema
2011-03-18 0:43 ` Greg Ungerer
2011-03-17 15:54 ` [PATCH 3/9] lpc2k: clk API Ithamar R. Adema
2011-03-17 22:08 ` Kevin Wells
2011-03-18 9:44 ` Ithamar R. Adema
2011-03-17 22:16 ` Kevin Wells
2011-03-17 22:29 ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 4/9] lpc2k: generic time and clockevents Ithamar R. Adema
2011-03-17 21:38 ` Jamie Iles
2011-03-17 22:00 ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 5/9] lpc2k: gpiolib Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 6/9] lpc2k: multifunction pin configuration Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 7/9] lpc2k: Add EmbeddedArtists LPC2478 Developer's Kit board Ithamar R. Adema
2011-03-17 22:07 ` Kevin Wells
2011-03-17 22:18 ` Ithamar R. Adema [this message]
2011-03-17 22:33 ` Kevin Wells
2011-03-17 22:49 ` Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 8/9] lpc2k: Add UART, SSP, and MCI devices Ithamar R. Adema
2011-03-17 15:54 ` [PATCH 9/9] lpc2k: defconfig for NXP LPC2K platform Ithamar R. Adema
2011-03-17 17:18 ` [PATCH 0/9] Support for NXP LPC2K SoCs Kevin Wells
2011-03-18 0:45 ` Greg Ungerer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1300400315.2138.103.camel@team-embedded-2 \
--to=ithamar.adema@team-embedded.nl \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).